From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE03AC43331 for ; Thu, 2 Apr 2020 10:28:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CBA22145D for ; Thu, 2 Apr 2020 10:28:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YZYGGubV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CBA22145D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJx4q-00025X-Jk for qemu-devel@archiver.kernel.org; Thu, 02 Apr 2020 06:28:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37924) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJx4A-0001W7-5C for qemu-devel@nongnu.org; Thu, 02 Apr 2020 06:27:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJx48-0008IF-38 for qemu-devel@nongnu.org; Thu, 02 Apr 2020 06:27:17 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:22772 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJx46-0008HK-Ri for qemu-devel@nongnu.org; Thu, 02 Apr 2020 06:27:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585823234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dmXCI1AvT6o1k9IK1RF4ERCwKFTfd6PtCsFVbJbFCag=; b=YZYGGubVbWkv2dHrjljeDRTCIiXD1RHHWz4L+rgMf6ZVa2xLlzRjMEqplnUnAq7LRY6U7w flJycN2kidsyHQvrjFtKqHBVbUNYtXc4fjaaZpP3EYugLTyszl148Z/G8nzu728PNdU63X 5pTtIg+iQZH0rKDTj/8Hes08qYMSvP0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-168-E1SAAFPHMN-cqBK44t-cGw-1; Thu, 02 Apr 2020 06:27:12 -0400 X-MC-Unique: E1SAAFPHMN-cqBK44t-cGw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 144E8800D5B; Thu, 2 Apr 2020 10:27:11 +0000 (UTC) Received: from gondolin (ovpn-113-176.ams2.redhat.com [10.36.113.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id C642510016DA; Thu, 2 Apr 2020 10:27:05 +0000 (UTC) Date: Thu, 2 Apr 2020 12:27:03 +0200 From: Cornelia Huck To: Christian Borntraeger Subject: Re: [PATCH v3 1/1] vl/s390x: fixup ram sizes for compat machines Message-ID: <20200402122703.60aaa235.cohuck@redhat.com> In-Reply-To: <416817db-686d-85e9-deeb-dc29e837d887@de.ibm.com> References: <20200401123754.109602-1-borntraeger@de.ibm.com> <285819e0-e23e-32ac-b061-a0b683baeb5a@redhat.com> <20200402112206.17c942de.cohuck@redhat.com> <416817db-686d-85e9-deeb-dc29e837d887@de.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?B?THVr?= =?UTF-8?B?w6HFoQ==?= Doktor , Thomas Huth , Janosch Frank , David Hildenbrand , qemu-devel , "Dr . David Alan Gilbert" , Halil Pasic , qemu-s390x , Igor Mammedov , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 2 Apr 2020 11:25:34 +0200 Christian Borntraeger wrote: > On 02.04.20 11:22, Cornelia Huck wrote: > > On Wed, 1 Apr 2020 15:14:12 +0200 > > David Hildenbrand wrote: > > > >> On 01.04.20 14:37, Christian Borntraeger wrote: > > > >>> +static ram_addr_t s390_fixup_ram_size(ram_addr_t sz) > >>> +{ > >>> + /* same logic as in sclp.c */ > >>> + int increment_size = 20; > >>> + ram_addr_t newsz; > >>> + > >>> + while ((sz >> increment_size) > MAX_STORAGE_INCREMENTS) { > >>> + increment_size++; > >>> + } > >>> + newsz = sz >> increment_size << increment_size; > >>> + > >>> + if (sz != newsz) { > >>> + qemu_printf("Ram size %" PRIu64 "MB was fixed up to %" PRIu64 > >>> + "MB to match machine restrictions. Consider updating " > >>> + "the guest definition.i\n", sz / MiB, newsz / MiB); > >> > >> Not sure if news/zs will be printed correctly in case ram_addr_t != > >> uint64_t. > > > > RAM_ADDR_FMT might be the right thing to use here? > > I tried that but it returns a hex value in bytes. This is unusable. Thats why I divided > by MiB. Nod. > We could simply do an u64 cast? Not sure if we might end up with "cast to integer of different length" values on some platforms (that I unfortunately don't have around to test). I hate that stuff.