From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6219CC43331 for ; Thu, 2 Apr 2020 11:41:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CE3E20757 for ; Thu, 2 Apr 2020 11:41:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VPfDspBD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CE3E20757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJyDW-0007cd-8f for qemu-devel@archiver.kernel.org; Thu, 02 Apr 2020 07:41:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51603) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJyCm-00070P-MI for qemu-devel@nongnu.org; Thu, 02 Apr 2020 07:40:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJyCl-0007PW-NS for qemu-devel@nongnu.org; Thu, 02 Apr 2020 07:40:16 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:53850 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJyCl-0007PC-Kh for qemu-devel@nongnu.org; Thu, 02 Apr 2020 07:40:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585827615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XRlISlhM6Y84l31Vxz3zpGEybbLy97qZDlRomqRO758=; b=VPfDspBDOjh9SXNRZ9ZYJ7U5LxMqGYgdoOMM0FPlVYQuEUQBrogrnbGgHemlZKBAEVGwKg V7duUegFVizQCBTUXcaZ8U93TruhBIEnBVidRCTdOWmQlHnzu3cBtku0sAYoCdCz2Qtnpv LAPCNe8FIC+nnvVKY+TA5tlMklLqXzE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-iFEKrpzFOR-kyg6etYGt8Q-1; Thu, 02 Apr 2020 07:40:11 -0400 X-MC-Unique: iFEKrpzFOR-kyg6etYGt8Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 52E3810CE786; Thu, 2 Apr 2020 11:40:10 +0000 (UTC) Received: from localhost (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id DD17538D; Thu, 2 Apr 2020 11:40:00 +0000 (UTC) Date: Thu, 2 Apr 2020 13:39:58 +0200 From: Igor Mammedov To: Cornelia Huck Subject: Re: [PATCH v3 1/1] vl/s390x: fixup ram sizes for compat machines Message-ID: <20200402133958.72fabf45@redhat.com> In-Reply-To: <20200402112735.6961297d.cohuck@redhat.com> References: <20200401123754.109602-1-borntraeger@de.ibm.com> <20200401183456.09ba3540@redhat.com> <20200402112735.6961297d.cohuck@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?B?THVrw6HFoQ==?= Doktor , Thomas Huth , Janosch Frank , David Hildenbrand , qemu-devel , "Dr . David Alan Gilbert" , Halil Pasic , Christian Borntraeger , qemu-s390x , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 2 Apr 2020 11:27:35 +0200 Cornelia Huck wrote: > On Wed, 1 Apr 2020 18:34:56 +0200 > Igor Mammedov wrote: > > > On Wed, 1 Apr 2020 08:37:54 -0400 > > Christian Borntraeger wrote: > > > > +static ram_addr_t s390_fixup_ram_size(ram_addr_t sz) > > > +{ > > > + /* same logic as in sclp.c */ > > > + int increment_size = 20; > > > + ram_addr_t newsz; > > > + > > > + while ((sz >> increment_size) > MAX_STORAGE_INCREMENTS) { > > > + increment_size++; > > > + } > > > + newsz = sz >> increment_size << increment_size; > > > + > > > + if (sz != newsz) { > > > + qemu_printf("Ram size %" PRIu64 "MB was fixed up to %" PRIu64 > > ^^^^^^^^ > > > > for unaware user it could be confusing as it could be read as 'value was increased' > > s/fixed up/amended/ might be better > > "rounded", perhaps? > > > > > > + "MB to match machine restrictions. Consider updating " > > > + "the guest definition.i\n", sz / MiB, newsz / MiB); > > > > also it might be better to use size_to_str() to format numbers > > The text explicitly talks about 'MB'... not sure if it would be > confusing if the user specified MB and ended up with GB or so in this > message. MB can be dropped, since it still might not match what user specified with -m it could be specified in b/kb/mb/gb over there so I'd drop MB and print value size_to_str() returns (it will add appropriate suffix if I'm not mistaken) > > > > > + } > > > + return newsz; > > > +} > > > + > > (If we can agree upon message and format, I'll happily fix that up when > applying.) > >