From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C8BC43331 for ; Thu, 2 Apr 2020 12:30:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D3E720757 for ; Thu, 2 Apr 2020 12:30:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NSZcP+Aj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D3E720757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJyzO-0006eL-A1 for qemu-devel@archiver.kernel.org; Thu, 02 Apr 2020 08:30:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59813) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJyya-0006AD-57 for qemu-devel@nongnu.org; Thu, 02 Apr 2020 08:29:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJyyY-0002Kf-CM for qemu-devel@nongnu.org; Thu, 02 Apr 2020 08:29:39 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:60451 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJyyY-0002K9-6r for qemu-devel@nongnu.org; Thu, 02 Apr 2020 08:29:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585830577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bUAkS8KGpZfm9vgqCVYBZBbcWBaj2Zh7VKC+Wd+PJao=; b=NSZcP+AjtN8fT2u79fnjZAUM0S34EbUHFz191CIJrOh40Q+hWrZ0iuc24qOEm+NKDC1L8K 36dvxaYgSQwBPh+2sG6C2CQCNmLp1dh3pdSCTXn3Gu9qnE9Uiix+Rd6br8vMi+Rl0nRN4t wdL4m/1o2zQD3dTXkYSF8xpQOnlBnk8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-436-Sgs0HyfCP3SNjyICYcojVQ-1; Thu, 02 Apr 2020 08:29:33 -0400 X-MC-Unique: Sgs0HyfCP3SNjyICYcojVQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 680558018AF; Thu, 2 Apr 2020 12:29:32 +0000 (UTC) Received: from localhost (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78F4AD768E; Thu, 2 Apr 2020 12:29:26 +0000 (UTC) Date: Thu, 2 Apr 2020 14:29:25 +0200 From: Igor Mammedov To: Anthony PERARD Subject: Re: [PATCH for-5.0] xen: fixup RAM memory region initialization Message-ID: <20200402142925.75e0c482@redhat.com> In-Reply-To: <20200330165248.GR4088@perard.uk.xensource.com> References: <20200327104828.12647-1-imammedo@redhat.com> <20200330165248.GR4088@perard.uk.xensource.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, rth@twiddle.net, qemu-devel@nongnu.org, ehabkost@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 30 Mar 2020 17:52:48 +0100 Anthony PERARD wrote: > On Fri, Mar 27, 2020 at 06:48:28AM -0400, Igor Mammedov wrote: > > Since bd457782b3b0 ("x86/pc: use memdev for RAM") Xen > > machine fails to start with: > > qemu-system-i386: xen: failed to populate ram at 0 > > > > The reason is that xen_ram_alloc() which is called by > > memory_region_init_ram(), compares memory region with > > statically allocated 'global' ram_memory memory region > > that it uses for RAM, and does nothing in case it matches. > > > > While it's possible feed machine->ram to xen_ram_alloc() > > in the same manner to keep that hack working, I'd prefer > > not to keep that circular dependency and try to untangle that. > > > > However it doesn't look trivial to fix, so as temporary > > fixup opt out Xen machine from memdev based RAM allocation, > > and let xen_ram_alloc() do its trick for now. > > > > Reported-by: Anthony PERARD > > Signed-off-by: Igor Mammedov > > Reviewed-by: Anthony PERARD > > That should work on most configs. But we also sometime use the "pc" > machine with accel=xen, to run without the "xen-platform" pci device, > but that would be less common. does following work for you in case of pc machine? diff --git a/hw/xen/xen-common.c b/hw/xen/xen-common.c index 15650d7f6a..f19c0883ae 100644 --- a/hw/xen/xen-common.c +++ b/hw/xen/xen-common.c @@ -151,6 +151,8 @@ static void xen_setup_post(MachineState *ms, AccelState *accel) static int xen_init(MachineState *ms) { + MachineClass *mc = MACHINE_GET_CLASS(ms); + xen_xc = xc_interface_open(0, 0, 0); if (xen_xc == NULL) { xen_pv_printf(NULL, 0, "can't open xen interface\n"); @@ -170,6 +172,10 @@ static int xen_init(MachineState *ms) return -1; } qemu_add_vm_change_state_handler(xen_change_state_handler, NULL); + /* + * opt out of system RAM being allocated by generic code + */ + m->default_ram_id = NULL; return 0; } > Thanks, >