From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v2 07/12] acpi: move aml builder code for rtc device
Date: Fri, 3 Apr 2020 10:04:57 +0200 [thread overview]
Message-ID: <20200403080502.8154-8-kraxel@redhat.com> (raw)
In-Reply-To: <20200403080502.8154-1-kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/i386/acpi-build.c | 17 -----------------
hw/rtc/mc146818rtc.c | 20 ++++++++++++++++++++
2 files changed, 20 insertions(+), 17 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 77fc9df74735..a5bc7764e611 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1131,22 +1131,6 @@ static Aml *build_fdc_device_aml(ISADevice *fdc)
return dev;
}
-static Aml *build_rtc_device_aml(void)
-{
- Aml *dev;
- Aml *crs;
-
- dev = aml_device("RTC");
- aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));
- crs = aml_resource_template();
- aml_append(crs, aml_io(AML_DECODE16, 0x0070, 0x0070, 0x10, 0x02));
- aml_append(crs, aml_irq_no_flags(8));
- aml_append(crs, aml_io(AML_DECODE16, 0x0072, 0x0072, 0x02, 0x06));
- aml_append(dev, aml_name_decl("_CRS", crs));
-
- return dev;
-}
-
static Aml *build_kbd_device_aml(void)
{
Aml *dev;
@@ -1243,7 +1227,6 @@ static void build_isa_devices_aml(Aml *table)
Aml *scope = aml_scope("_SB.PCI0.ISA");
Object *obj = object_resolve_path_type("", TYPE_ISA_BUS, &ambiguous);
- aml_append(scope, build_rtc_device_aml());
aml_append(scope, build_kbd_device_aml());
aml_append(scope, build_mouse_device_aml());
if (fdc) {
diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c
index dc4269cc55cb..814263c01a90 100644
--- a/hw/rtc/mc146818rtc.c
+++ b/hw/rtc/mc146818rtc.c
@@ -27,6 +27,7 @@
#include "qemu/cutils.h"
#include "qemu/module.h"
#include "qemu/bcd.h"
+#include "hw/acpi/aml-build.h"
#include "hw/irq.h"
#include "hw/qdev-properties.h"
#include "qemu/timer.h"
@@ -1008,13 +1009,32 @@ static void rtc_resetdev(DeviceState *d)
}
}
+static void rtc_build_aml(ISADevice *isadev, Aml *scope)
+{
+ Aml *dev;
+ Aml *crs;
+
+ crs = aml_resource_template();
+ aml_append(crs, aml_io(AML_DECODE16, 0x0070, 0x0070, 0x10, 0x02));
+ aml_append(crs, aml_irq_no_flags(8));
+ aml_append(crs, aml_io(AML_DECODE16, 0x0072, 0x0072, 0x02, 0x06));
+
+ dev = aml_device("RTC");
+ aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));
+ aml_append(dev, aml_name_decl("_CRS", crs));
+
+ aml_append(scope, dev);
+}
+
static void rtc_class_initfn(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
+ ISADeviceClass *isa = ISA_DEVICE_CLASS(klass);
dc->realize = rtc_realizefn;
dc->reset = rtc_resetdev;
dc->vmsd = &vmstate_rtc;
+ isa->build_aml = rtc_build_aml;
device_class_set_props(dc, mc146818rtc_properties);
}
--
2.18.2
next prev parent reply other threads:[~2020-04-03 8:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:04 [PATCH v2 00/12] acpi: i386 tweaks Gerd Hoffmann
2020-04-03 8:04 ` [PATCH v2 01/12] move 'typedef Aml' to qemu/types.h Gerd Hoffmann
2020-04-03 9:41 ` Igor Mammedov
2020-04-03 8:04 ` [PATCH v2 02/12] acpi: add aml builder stubs Gerd Hoffmann
2020-04-03 9:43 ` Igor Mammedov
2020-04-03 8:04 ` [PATCH v2 03/12] acpi: drop pointless _STA method Gerd Hoffmann
2020-04-03 9:45 ` Igor Mammedov
2020-04-03 8:04 ` [PATCH v2 04/12] acpi: serial: don't use " Gerd Hoffmann
2020-04-03 10:00 ` Igor Mammedov
2020-04-06 10:20 ` Gerd Hoffmann
2020-04-03 8:04 ` [PATCH v2 05/12] acpi: parallel: " Gerd Hoffmann
2020-04-03 10:01 ` Igor Mammedov
2020-04-03 8:04 ` [PATCH v2 06/12] acpi: add ISADeviceClass->build_aml() Gerd Hoffmann
2020-04-03 10:05 ` Igor Mammedov
2020-04-06 10:22 ` Igor Mammedov
2020-04-07 10:18 ` Gerd Hoffmann
2020-04-03 8:04 ` Gerd Hoffmann [this message]
2020-04-03 10:09 ` [PATCH v2 07/12] acpi: move aml builder code for rtc device Igor Mammedov
2020-04-06 8:25 ` Gerd Hoffmann
2020-04-06 12:17 ` Igor Mammedov
2020-04-07 10:26 ` Gerd Hoffmann
2020-04-08 11:27 ` Igor Mammedov
2020-04-08 12:59 ` Gerd Hoffmann
2020-04-08 20:28 ` Cameron Esfahani via
2020-04-03 8:04 ` [PATCH v2 08/12] acpi: move aml builder code for serial device Gerd Hoffmann
2020-04-03 10:10 ` Igor Mammedov
2020-04-03 8:04 ` [PATCH v2 09/12] acpi: move aml builder code for parallel device Gerd Hoffmann
2020-04-03 10:12 ` Igor Mammedov
2020-04-03 10:16 ` Igor Mammedov
2020-04-06 10:26 ` Gerd Hoffmann
2020-04-06 11:39 ` Paolo Bonzini
2020-04-06 12:14 ` Igor Mammedov
2020-04-03 8:05 ` [PATCH v2 10/12] acpi: move aml builder code for floppy device Gerd Hoffmann
2020-04-03 8:05 ` [PATCH v2 11/12] acpi: move aml builder code for i8042 (kbd+mouse) device Gerd Hoffmann
2020-04-03 8:05 ` [PATCH v2 12/12] acpi: factor out fw_cfg_add_acpi_dsdt() Gerd Hoffmann
2020-04-03 8:50 ` [PATCH v2 00/12] acpi: i386 tweaks no-reply
2020-04-03 9:09 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403080502.8154-8-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).