From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6823DC43331 for ; Fri, 3 Apr 2020 08:49:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32C8A20675 for ; Fri, 3 Apr 2020 08:49:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HmTYqU30" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32C8A20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKI16-0007vB-AZ for qemu-devel@archiver.kernel.org; Fri, 03 Apr 2020 04:49:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48385) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKHzK-00069f-F4 for qemu-devel@nongnu.org; Fri, 03 Apr 2020 04:47:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKHzJ-0003R3-F5 for qemu-devel@nongnu.org; Fri, 03 Apr 2020 04:47:42 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53980 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jKHzJ-0003Pd-9e for qemu-devel@nongnu.org; Fri, 03 Apr 2020 04:47:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585903659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9sKGqgGEyIeINfCUjjHIV7wvsK1dKAqw+nx72JqPbPQ=; b=HmTYqU30mPatrwtoqSKqk5+/Kw7dkzEmafhRIKpVBwOBUuXBL+raZ5j5YCJUUQSoy/sbtW 3sBYjrbFc30i7PKERQoFqewZIZFdzzj25j7B7UN6hYjM40w+9fW24WOTbmFHJSFxou6aey Wt2je9pgl2NphoXcKXtT1e8Yet0U0E8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-hmT9kdSvOj-NLZZgZ_kkcw-1; Fri, 03 Apr 2020 04:47:36 -0400 X-MC-Unique: hmT9kdSvOj-NLZZgZ_kkcw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D43A7107ACC7; Fri, 3 Apr 2020 08:47:34 +0000 (UTC) Received: from linux.fritz.box (ovpn-113-132.ams2.redhat.com [10.36.113.132]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B101660BF3; Fri, 3 Apr 2020 08:47:30 +0000 (UTC) Date: Fri, 3 Apr 2020 10:47:29 +0200 From: Kevin Wolf To: Dietmar Maurer Subject: Re: bdrv_drained_begin deadlock with io-threads Message-ID: <20200403084729.GB5336@linux.fritz.box> References: <20200401181256.GB27663@linux.fritz.box> <1403939459.52.1585765681569@webmail.proxmox.com> <20200401184431.GD27663@linux.fritz.box> <903538836.29.1585818619688@webmail.proxmox.com> <20200402121403.GB4006@linux.fritz.box> <20200402142524.GD4006@linux.fritz.box> <1043934808.59.1585842050330@webmail.proxmox.com> <20200402164744.GE4006@linux.fritz.box> <20200402171007.GF4006@linux.fritz.box> <2091214547.43.1585902379938@webmail.proxmox.com> MIME-Version: 1.0 In-Reply-To: <2091214547.43.1585902379938@webmail.proxmox.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, Vladimir Sementsov-Ogievskiy , "qemu-devel@nongnu.org" , Stefan Hajnoczi , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 03.04.2020 um 10:26 hat Dietmar Maurer geschrieben: > > With the following patch, it seems to survive for now. I'll give it som= e > > more testing tomorrow (also qemu-iotests to check that I didn't > > accidentally break something else.) >=20 > Wow, that was fast! Seems your patch fixes the bug! >=20 > I wonder what commit introduced that problem, maybe: >=20 > https://github.com/qemu/qemu/commit/cf3129323f900ef5ddbccbe86e4fa801e88c5= 66e#diff-7cb66df56045598b75a219eebc27efb6 >=20 > If so, version 4.1.X in not affected by this bug, but 4.2.0 and later? Yes, I'm pretty sure that's the one. Kevin