From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Janosch Frank <frankja@linux.vnet.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Halil Pasic <pasic@linux.ibm.com>,
qemu-s390x <qemu-s390x@nongnu.org>,
Marc Hartmayer <mhartmay@linux.ibm.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v2] s390x/pv: Retry ioctls on -EINTR
Date: Fri, 3 Apr 2020 17:22:39 +0200 [thread overview]
Message-ID: <20200403172239.4985c7ae.cohuck@redhat.com> (raw)
In-Reply-To: <20200327124616.34866-1-borntraeger@de.ibm.com>
On Fri, 27 Mar 2020 08:46:16 -0400
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> PV_ENABLE (and maybe others) might return -EINTR when a signal is
> pending. See the Linux kernel patch "s390/gmap: return proper error code
> on ksm unsharing" for details. Let us retry the ioctl in that case.
>
> Fixes: 4d226deafc44 ("s390x: protvirt: Support unpack facility")
I'll update that when the commit ids are stable.
> Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> Acked-by: Janosch Frank <frankja@linux.vnet.ibm.com>
> Tested-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> hw/s390x/pv.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Thanks, queued to s390-next.
prev parent reply other threads:[~2020-04-03 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 12:46 [PATCH v2] s390x/pv: Retry ioctls on -EINTR Christian Borntraeger
2020-04-03 15:22 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403172239.4985c7ae.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=mhartmay@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).