From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B941C2BA18 for ; Mon, 6 Apr 2020 07:33:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AF2C20672 for ; Mon, 6 Apr 2020 07:33:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=yandex-team.ru header.i=@yandex-team.ru header.b="l9W1LXCN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AF2C20672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=yandex-team.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLMGY-0005hV-HO for qemu-devel@archiver.kernel.org; Mon, 06 Apr 2020 03:33:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56650) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLMFe-0005GP-6Y for qemu-devel@nongnu.org; Mon, 06 Apr 2020 03:33:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLMFa-0003jy-OZ for qemu-devel@nongnu.org; Mon, 06 Apr 2020 03:32:56 -0400 Received: from forwardcorp1o.mail.yandex.net ([95.108.205.193]:56616) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLMFa-0003ZQ-21 for qemu-devel@nongnu.org; Mon, 06 Apr 2020 03:32:54 -0400 Received: from mxbackcorp1g.mail.yandex.net (mxbackcorp1g.mail.yandex.net [IPv6:2a02:6b8:0:1402::301]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id 8EF5D2E168C; Mon, 6 Apr 2020 10:32:48 +0300 (MSK) Received: from myt4-18a966dbd9be.qloud-c.yandex.net (myt4-18a966dbd9be.qloud-c.yandex.net [2a02:6b8:c00:12ad:0:640:18a9:66db]) by mxbackcorp1g.mail.yandex.net (mxbackcorp/Yandex) with ESMTP id uKdPiLnpqO-WlNikLDu; Mon, 06 Apr 2020 10:32:48 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1586158368; bh=WUWKs+jJ4yRaXGerbwTBbniYvRdWdne4xUsVZpY3CRo=; h=In-Reply-To:Message-ID:Subject:To:From:References:Date:Cc; b=l9W1LXCNks/CmvlCYmyuR+CYCA5/GNX7fiYUGUmh+LDdyIkU+45I0XXcTmMeXiQ9g 51SKK+44z//E8GuyYeLAS7d1wBsWq/0cXedY7sgqo5FixPno5hUow4z+PV3euKplmx 6/Glyp/y7iKKpo6nWNtFLa6mp9rm+cKHcEmLlNRk= Authentication-Results: mxbackcorp1g.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Received: from unknown (unknown [2a02:6b8:b080:7216::1:e]) by myt4-18a966dbd9be.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id RUTwJaYcmF-WlWqbNfQ; Mon, 06 Apr 2020 10:32:47 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Mon, 6 Apr 2020 10:32:46 +0300 From: Roman Kagan To: "Maciej S. Szmigiero" Subject: Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry Message-ID: <20200406073246.GA7707@rvkaganb> Mail-Followup-To: Roman Kagan , "Maciej S. Szmigiero" , Jon Doron , QEMU , Evgeny Yakovlev , ehabkost@redhat.com, Paolo Bonzini , Vitaly Kuznetsov , Liran Alon , Roman Kagan References: <20200403142308.82990-1-arilou@gmail.com> <20200403142308.82990-6-arilou@gmail.com> <76017793-735b-4bb5-0e69-ecded78af54d@maciej.szmigiero.name> <9b9c42d3-af9e-25e9-210e-c58ee5975941@maciej.szmigiero.name> <472544e7-498a-4e28-06e9-83c102d6436b@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <472544e7-498a-4e28-06e9-83c102d6436b@maciej.szmigiero.name> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 95.108.205.193 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Evgeny Yakovlev , Jon Doron , QEMU , Liran Alon , Roman Kagan , Paolo Bonzini , Vitaly Kuznetsov , ehabkost@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Apr 03, 2020 at 11:00:27PM +0200, Maciej S. Szmigiero wrote: > It seems to me that Roman might not be getting our e-mails since his > new e-mail address seems to be "rvkagan@yandex-team.ru". Indeed. I'm subscribed with my new address to qemu-devel ML but must have missed this series. > @Roman, are you with us? Yes ;) So what are your plans regarding this patchset? Thanks, Roman. > On 03.04.2020 19:18, Maciej S. Szmigiero wrote: > > Hi Jon, > > > > The patches are available here: > > https://github.com/maciejsszmigiero/qemu.git in "vmbus-patches" branch. > > > > Please note that these patches don't have Roman's "Signed-off-by:" tags, > > so I haven't applied mine, either. > > > > If you are able to establish a proper SoB chain then please also add: > > "Signed-off-by: Maciej S. Szmigiero ". > > > > Thanks for the effort, > > Maciej > > > > On 03.04.2020 17:30, Jon Doron wrote: > >> Thank you Maciej it seems like your version is really ahead I'll do > >> the required work and merge it so i can submit a v2 with the latest > >> patchset from Roman > >> > >> On Fri, Apr 3, 2020 at 6:06 PM Jon Doron wrote: > >>> > >>> Thank you Maciej, I based it on top of what Denis (den@openvz.org) gave me > >>> which was this: > >>> https://ftp.openvz.org/virtuozzo/releases/openvz-7.0.12-288/source/SRPMS/q/qemu-kvm-vz-2.12.0-33.vz7.14.4.src.rpm > >>> > >>> Do you think you have a more recent version I dont mind diffing and > >>> resubmitting a new version of the patchset? > >>> > >>> Thanks, > >>> -- Jon. > >>> > >>> On Fri, Apr 3, 2020 at 5:56 PM Maciej S. Szmigiero > >>> wrote: > >>>> > >>>> Hi Jon, > >>>> > >>>> On 03.04.2020 16:23, Jon Doron wrote: > >>>>> Guest OS uses ACPI to discover vmbus presence. Add a corresponding > >>>>> entry to DSDT in case vmbus has been enabled. > >>>>> > >>>>> Experimentally Windows guests were found to require this entry to > >>>>> include two IRQ resources, so this patch adds two semi-arbitrarily > >>>>> chosen ones (7 and 13). This results, in particular, in parallel port > >>>>> conflicting with vmbus. > >>>>> > >>>>> TODO: discover and use spare IRQs to avoid conflicts. > >>>>> > >>>>> Signed-off-by: Evgeny Yakovlev > >>>>> Signed-off-by: Roman Kagan > >>>>> Signed-off-by: Jon Doron > >>>> > >>>> Nice work, thanks! > >>>> > >>>> However, it seems to be based on the code version that was posted in > >>>> February 2018, and not the latest version in OpenVZ qemu repository > >>>> dated October 2019: > >>>> https://src.openvz.org/projects/UP/repos/qemu/commits?until=refs%2Fheads%2Fvmbus > >>>> > >>>> This newer version has slightly different API here and there. > >>>> Any particular reason for selecting that older version for porting? > >>>> > >>>> I have actually rebased this latest version on the top of the current > >>>> QEMU master, and it basically seems to work fine. > >>>> However, I haven't done extensive tests whether there isn't a memory leak > >>>> somewhere or so on. > >>>> > >>>> Maciej > > >