From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7463EC2BA1E for ; Mon, 6 Apr 2020 14:11:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4219623A52 for ; Mon, 6 Apr 2020 14:11:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WZnI0OcV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4219623A52 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLST3-0004E1-Fk for qemu-devel@archiver.kernel.org; Mon, 06 Apr 2020 10:11:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56957) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLSSR-0003cd-Cf for qemu-devel@nongnu.org; Mon, 06 Apr 2020 10:10:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLSSM-0001eP-6X for qemu-devel@nongnu.org; Mon, 06 Apr 2020 10:10:35 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:34408 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLSSM-0001eG-2q for qemu-devel@nongnu.org; Mon, 06 Apr 2020 10:10:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586182229; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p7AQ3vB2nkar6sre7AESSQQR5rDepPyZcpMhSIsdY6E=; b=WZnI0OcVT49dm97l7w856BoH14NWSXQuNo2pmBoDGPrxMVB6NcY7VIt2ma17TM6k9MVlf/ XEbj9M+6RvvTrnZrXujzP3b1uk3pnMRoIhWPqiZoHX9oZ/cXloCzJs+NeDivicnGtVkGzo HYmRYajQzO8I6yrbgC9oeVFHuwKm5JM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-v4Kwrj7cO6ObkxHtbEnMDA-1; Mon, 06 Apr 2020 10:10:27 -0400 X-MC-Unique: v4Kwrj7cO6ObkxHtbEnMDA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BBB4B8017FC; Mon, 6 Apr 2020 14:10:26 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E0E644DA25; Mon, 6 Apr 2020 14:10:23 +0000 (UTC) Date: Mon, 6 Apr 2020 15:10:19 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Subject: Re: Questionable aspects of QEMU Error's design Message-ID: <20200406141019.GQ794362@redhat.com> References: <87o8sblgto.fsf@dusky.pond.sub.org> <87blo7heag.fsf@dusky.pond.sub.org> <87sghjfre8.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87sghjfre8.fsf@dusky.pond.sub.org> User-Agent: Mutt/1.13.3 (2020-01-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-devel@nongnu.org, Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, Apr 04, 2020 at 12:59:27PM +0200, Markus Armbruster wrote: > Paolo, Daniel, Eduardo, >=20 > Please pick one for QOM: > * Return true on success, false on error. Looks like >=20 > if (!object_property_set_bool(..., errp)) { > return; > } My preference is this one, since it aligns with GLib recommendations for error reporting & is simple & concise. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberrange= :| |: https://libvirt.org -o- https://fstop138.berrange.com= :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange= :|