From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E85AC2BA19 for ; Mon, 6 Apr 2020 12:15:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBF1D208E4 for ; Mon, 6 Apr 2020 12:15:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fnWm7U1T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBF1D208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLQfA-00058A-0l for qemu-devel@archiver.kernel.org; Mon, 06 Apr 2020 08:15:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39037) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLQeE-0004FN-Q1 for qemu-devel@nongnu.org; Mon, 06 Apr 2020 08:14:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLQeD-0005mE-NI for qemu-devel@nongnu.org; Mon, 06 Apr 2020 08:14:38 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:49887 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLQeD-0005ly-KM for qemu-devel@nongnu.org; Mon, 06 Apr 2020 08:14:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586175277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QY0gpkMNX1ayi4oqfUlaUr6JB9BzTeQP+u++/8/5RFA=; b=fnWm7U1T0xwAcDbqbYQkQhRhao3cln3AuQXj4CQjxfvJLg9YlSiuf4rMvjNo0Blhs8QctH wlT4QY2JHPpa4I7hc0pR3VieWReW3zgIxH3hSkmqQ44UQaG//9dbYeGkiqH7U6DRDIl66O NzWnfnJk8n6lAJVqbBRyqB+9OcG2300= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-27-Lt2jYZnyMmeUXFAPb7sqXA-1; Mon, 06 Apr 2020 08:14:33 -0400 X-MC-Unique: Lt2jYZnyMmeUXFAPb7sqXA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9EA66107ACCC; Mon, 6 Apr 2020 12:14:32 +0000 (UTC) Received: from localhost (unknown [10.40.208.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F6141001925; Mon, 6 Apr 2020 12:14:18 +0000 (UTC) Date: Mon, 6 Apr 2020 14:14:16 +0200 From: Igor Mammedov To: Gerd Hoffmann Subject: Re: [PATCH v2 09/12] acpi: move aml builder code for parallel device Message-ID: <20200406141416.753b2023@redhat.com> In-Reply-To: <20200406102652.lf2yq4wkm2lylgzf@sirius.home.kraxel.org> References: <20200403080502.8154-1-kraxel@redhat.com> <20200403080502.8154-10-kraxel@redhat.com> <20200403121210.30a010cb@redhat.com> <20200403121601.35099bf5@redhat.com> <20200406102652.lf2yq4wkm2lylgzf@sirius.home.kraxel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Max Reitz , Paolo Bonzini , =?UTF-8?B?TWFyYy1B?= =?UTF-8?B?bmRyw6k=?= Lureau , John Snow , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 6 Apr 2020 12:26:52 +0200 Gerd Hoffmann wrote: > On Fri, Apr 03, 2020 at 12:16:01PM +0200, Igor Mammedov wrote: > > On Fri, 3 Apr 2020 12:12:10 +0200 > > Igor Mammedov wrote: > > > > > On Fri, 3 Apr 2020 10:04:59 +0200 > > > Gerd Hoffmann wrote: > > > > > [...] > > > > +static void parallel_isa_build_aml(ISADevice *isadev, Aml *scope) > > > > +{ > > > > + ISAParallelState *isa = ISA_PARALLEL(isadev); > > > > + Aml *dev; > > > > + Aml *crs; > > > > + > > > > + if (isa->iobase != 0x0378) { > > > > + return; > > > > + } > > if device is present why should we skip adding it to DSDT? > > Well, that is the current state of affairs, only the first parallel > ports shows up in the dsdt. And given how rare parallel ports are these > days I didn't bother changing that ... > > We can handle this simliar to serial lines though, incremental below. > Do you prefer that? yep (with Paolo's comment addressed) > > take care, > Gerd > > =================================== cut here ======================= > From 617797cf42e56e18d5d62cb171af00c28589caba Mon Sep 17 00:00:00 2001 > From: Gerd Hoffmann > Date: Mon, 6 Apr 2020 12:17:59 +0200 > Subject: [PATCH] [fixup] parallel > > --- > hw/char/parallel.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/hw/char/parallel.c b/hw/char/parallel.c > index 2bff1f17fda7..7157d6816b77 100644 > --- a/hw/char/parallel.c > +++ b/hw/char/parallel.c > @@ -572,10 +572,16 @@ static void parallel_isa_realizefn(DeviceState *dev, Error **errp) > static void parallel_isa_build_aml(ISADevice *isadev, Aml *scope) > { > ISAParallelState *isa = ISA_PARALLEL(isadev); > + int i, uid = 0; > Aml *dev; > Aml *crs; > > - if (isa->iobase != 0x0378) { > + for (i = 0; i < ARRAY_SIZE(isa_parallel_io); i++) { > + if (isa->iobase == isa_parallel_io[i]) { > + uid = i + 1; > + } > + } > + if (!uid) { > return; > } > > @@ -583,8 +589,9 @@ static void parallel_isa_build_aml(ISADevice *isadev, Aml *scope) > aml_append(crs, aml_io(AML_DECODE16, 0x0378, 0x0378, 0x08, 0x08)); > aml_append(crs, aml_irq_no_flags(7)); > > - dev = aml_device("LPT"); > + dev = aml_device("LPT%d", uid); > aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0400"))); > + aml_append(dev, aml_name_decl("_UID", aml_int(uid))); > aml_append(dev, aml_name_decl("_STA", aml_int(0xf))); > aml_append(dev, aml_name_decl("_CRS", crs)); >