From: David Gibson <david@gibson.dropbear.id.au>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Alex Bennee <alex.bennee@linaro.org>,
Claudio Fontana <cfontana@suse.de>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH] configure: check for bison, flex before dtc submodule build
Date: Wed, 8 Apr 2020 11:57:17 +1000 [thread overview]
Message-ID: <20200408015717.GA44664@umbus.fritz.box> (raw)
In-Reply-To: <CAFEAcA9SYT227B9K7yHcv_J==r4xZ1spUSNzL_bRXUpAjT5QVA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
On Tue, Apr 07, 2020 at 12:20:15PM +0100, Peter Maydell wrote:
> On Tue, 7 Apr 2020 at 12:16, Claudio Fontana <cfontana@suse.de> wrote:
> >
> > if fdt is required, and the system DTC (libfdt) is not usable,
> > check for the dtc submodule requirements before trying to build it,
> > and error out with a helpful message in case the dependencies are not met.
> >
> > Signed-off-by: Claudio Fontana <cfontana@suse.de>
>
> Does the dtc module actually need bison/flex, or does it just
> print an ugly warning about it? We only want the 'libfdt' part
> of dtc, which doesn't need the parser, we don't need to build
> the actual dtc compiler.
Assuming we're just invoking "make libfdt" within the submodule,
rather than "make" which will build dtc as well, then bison / flex
shouldn't be needed.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-08 2:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 11:16 [PATCH] configure: check for bison, flex before dtc submodule build Claudio Fontana
2020-04-07 11:20 ` Peter Maydell
2020-04-07 15:21 ` Claudio Fontana
2020-04-08 1:57 ` David Gibson [this message]
2020-04-08 7:52 ` Claudio Fontana
2020-04-08 8:00 ` David Gibson
2020-04-08 8:08 ` Claudio Fontana
2020-04-08 8:36 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408015717.GA44664@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).