From: David Gibson <david@gibson.dropbear.id.au>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: alex.bennee@linaro.org, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org, laurent@vivier.eu
Subject: Re: [PATCH for-5.0?] linux-user/ppc: Fix padding in mcontext_t for ppc64
Date: Wed, 8 Apr 2020 12:10:06 +1000 [thread overview]
Message-ID: <20200408021006.GB44664@umbus.fritz.box> (raw)
In-Reply-To: <20200407032105.26711-1-richard.henderson@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]
On Mon, Apr 06, 2020 at 08:21:05PM -0700, Richard Henderson wrote:
> The padding that was added in 95cda4c44ee was added to a union,
> and so it had no effect. This fixes misalignment errors detected
> by clang sanitizers for ppc64 and ppc64le.
>
> In addition, only ppc64 allocates space for VSX registers, so do
> not save them for ppc32. The kernel only has references to
> CONFIG_SPE in signal_32.c, so do not attempt to save them for ppc64.
>
> Fixes: 95cda4c44ee
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Applied to ppc-for-5.0, thanks.
> ---
>
> Note that ppc64abi32 is *not* fixed by this patch. It looks to
> me that all of the defined(TARGET_PPC64) tests in this file are
> incorrect, and that we should instead be testing TARGET_ABI_BITS
> vs 32/64. In addition, virtually all of the target_ulong structure
> members would need to be abi_ulong.
>
> Should we in fact disable ppc64abi32?
> I can't see how it could work enough to be useful as-is.
Yeah, I think so. Last time we had a problem in this area, I couldn't
even figure out what ppc64abi32 was supposed to *be*, let alone what
the use case for it is. Given that, it's hard to imagine it's been
working (whatever that means) any time recently.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-08 2:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 3:21 [PATCH for-5.0?] linux-user/ppc: Fix padding in mcontext_t for ppc64 Richard Henderson
2020-04-07 11:09 ` Laurent Vivier
2020-04-08 2:10 ` David Gibson [this message]
2020-04-08 3:44 ` Richard Henderson
2020-04-08 4:33 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408021006.GB44664@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).