qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fredrik Strupe <fredrik@strupe.net>
To: qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: Fredrik Strupe <fredrik@strupe.net>
Subject: [PATCH 1/2] target/arm: Make VQDMULL undefined when U=1
Date: Wed,  8 Apr 2020 13:59:53 +0200	[thread overview]
Message-ID: <20200408115953.1158-1-fredrik@strupe.net> (raw)

According to Arm ARM, VQDMULL is only valid when U=0, while having
U=1 is unallocated.

Signed-off-by: Fredrik Strupe <fredrik@strupe.net>
Fixes: 695272dcb976 ("target-arm: Handle UNDEF cases for Neon 3-regs-different-widths")
---
 target/arm/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/translate.c b/target/arm/translate.c
index 9f9f4e19e0..dfe9dbbcfd 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -5817,7 +5817,7 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn)
                     {0, 0, 0, 0}, /* VMLSL */
                     {0, 0, 0, 9}, /* VQDMLSL */
                     {0, 0, 0, 0}, /* Integer VMULL */
-                    {0, 0, 0, 1}, /* VQDMULL */
+                    {0, 0, 0, 9}, /* VQDMULL */
                     {0, 0, 0, 0xa}, /* Polynomial VMULL */
                     {0, 0, 0, 7}, /* Reserved: always UNDEF */
                 };
-- 
2.20.1



             reply	other threads:[~2020-04-08 14:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 11:59 Fredrik Strupe [this message]
2020-04-08 11:59 ` [PATCH 2/2] target/arm: Fail on invalid size for VMUL (float) Fredrik Strupe
2020-04-08 16:27   ` Peter Maydell
2020-04-09 17:36     ` Fredrik Strupe
2020-04-30 15:51 ` [PATCH 1/2] target/arm: Make VQDMULL undefined when U=1 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200408115953.1158-1-fredrik@strupe.net \
    --to=fredrik@strupe.net \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).