* [PATCH for-5.0] vl.c: error out if -mem-path is used together with -M memory-backend
@ 2020-04-09 13:41 Igor Mammedov
2020-04-09 14:10 ` Marc-André Lureau
0 siblings, 1 reply; 2+ messages in thread
From: Igor Mammedov @ 2020-04-09 13:41 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, peter.maydell
the former is not actually used by explicit backend, so instead of
silently ignoring the option in non valid context, exit with error.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
softmmu/vl.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 58a40bcfc1..32c0047889 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -4315,6 +4315,11 @@ void qemu_init(int argc, char **argv, char **envp)
"explicitly specified 'memory-backend' property");
exit(EXIT_FAILURE);
}
+ if (mem_path) {
+ error_report("'-mem-path' can't be used together with"
+ "'-machine memory-backend'");
+ exit(EXIT_FAILURE);
+ }
ram_size = backend_size;
}
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH for-5.0] vl.c: error out if -mem-path is used together with -M memory-backend
2020-04-09 13:41 [PATCH for-5.0] vl.c: error out if -mem-path is used together with -M memory-backend Igor Mammedov
@ 2020-04-09 14:10 ` Marc-André Lureau
0 siblings, 0 replies; 2+ messages in thread
From: Marc-André Lureau @ 2020-04-09 14:10 UTC (permalink / raw)
To: Igor Mammedov; +Cc: Paolo Bonzini, QEMU, Peter Maydell
On Thu, Apr 9, 2020 at 3:41 PM Igor Mammedov <imammedo@redhat.com> wrote:
>
> the former is not actually used by explicit backend, so instead of
> silently ignoring the option in non valid context, exit with error.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> softmmu/vl.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index 58a40bcfc1..32c0047889 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -4315,6 +4315,11 @@ void qemu_init(int argc, char **argv, char **envp)
> "explicitly specified 'memory-backend' property");
> exit(EXIT_FAILURE);
> }
> + if (mem_path) {
> + error_report("'-mem-path' can't be used together with"
> + "'-machine memory-backend'");
> + exit(EXIT_FAILURE);
> + }
> ram_size = backend_size;
> }
>
> --
> 2.18.1
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-09 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-09 13:41 [PATCH for-5.0] vl.c: error out if -mem-path is used together with -M memory-backend Igor Mammedov
2020-04-09 14:10 ` Marc-André Lureau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).