From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: kwolf@redhat.com, fam@euphon.net, qemu-block@nongnu.org,
qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org
Subject: Re: [PATCH for-5.0? 0/9] block/io: safer inc/dec in_flight sections
Date: Thu, 9 Apr 2020 18:00:34 +0100 [thread overview]
Message-ID: <20200409170034.GD319181@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200408093051.9893-1-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
On Wed, Apr 08, 2020 at 12:30:42PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> This is inspired by Kevin's
> "block: Fix blk->in_flight during blk_wait_while_drained()" series.
>
> So, like it's now done for block-backends, let's expand
> in_flight-protected sections for bdrv_ interfaces, including
> coroutine_enter and BDRV_POLL_WHILE loop into these sections.
This looks like a code improvement but let's leave it for the next
release since QEMU 5.0 is in freeze and this patch series does not fix a
specific user-visible bug.
I will review this in depth next week. Thanks!
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-04-09 17:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 9:30 [PATCH for-5.0? 0/9] block/io: safer inc/dec in_flight sections Vladimir Sementsov-Ogievskiy
2020-04-08 9:30 ` [PATCH 1/9] block/io: refactor bdrv_is_allocated_above to run only one coroutine Vladimir Sementsov-Ogievskiy
2020-04-20 15:56 ` Stefan Hajnoczi
2020-04-08 9:30 ` [PATCH 2/9] block/io: refactor bdrv_co_ioctl: move aio stuff to corresponding block Vladimir Sementsov-Ogievskiy
2020-04-20 15:57 ` Stefan Hajnoczi
2020-04-08 9:30 ` [PATCH 3/9] block/io: move flush and pdiscard stuff down Vladimir Sementsov-Ogievskiy
2020-04-20 16:01 ` Stefan Hajnoczi
2020-04-08 9:30 ` [PATCH 4/9] block/io: move bdrv_rw_co_entry and friends down Vladimir Sementsov-Ogievskiy
2020-04-20 16:04 ` Stefan Hajnoczi
2020-04-27 14:11 ` Vladimir Sementsov-Ogievskiy
2020-04-08 9:30 ` [PATCH 5/9] block/io: expand in_flight inc/dec section: simple cases Vladimir Sementsov-Ogievskiy
2020-04-20 16:22 ` Stefan Hajnoczi
2020-04-22 13:47 ` Vladimir Sementsov-Ogievskiy
2020-04-22 16:06 ` Stefan Hajnoczi
2020-04-08 9:30 ` [PATCH 6/9] block/io: expand in_flight inc/dec section: block-status Vladimir Sementsov-Ogievskiy
2020-04-20 16:44 ` Stefan Hajnoczi
2020-04-08 9:30 ` [PATCH 7/9] block/io: add bdrv_do_pwrite_zeroes Vladimir Sementsov-Ogievskiy
2020-04-20 16:38 ` Stefan Hajnoczi
2020-04-08 9:30 ` [PATCH 8/9] block/io: move bdrv_make_zero under block-status Vladimir Sementsov-Ogievskiy
2020-04-20 16:40 ` Stefan Hajnoczi
2020-04-08 9:30 ` [PATCH 9/9] block/io: expand in_flight inc/dec section: bdrv_make_zero Vladimir Sementsov-Ogievskiy
2020-04-20 16:43 ` Stefan Hajnoczi
2020-04-08 10:15 ` [PATCH for-5.0? 0/9] block/io: safer inc/dec in_flight sections no-reply
2020-04-08 10:22 ` no-reply
2020-04-08 10:25 ` no-reply
2020-04-09 17:00 ` Stefan Hajnoczi [this message]
2020-04-09 18:49 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409170034.GD319181@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).