From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb
Date: Thu, 9 Apr 2020 22:15:27 +0100 [thread overview]
Message-ID: <20200409211529.5269-10-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200409211529.5269-1-alex.bennee@linaro.org>
From: Peter Xu <peterx@redhat.com>
We should only pass in gdb_get_reg16() with the GByteArray* object
itself, no need to shift. Without this patch, gdb remote attach will
crash QEMU.
Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200409164954.36902-3-peterx@redhat.com>
---
target/i386/gdbstub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c
index f3d23b614ee..b98a99500ae 100644
--- a/target/i386/gdbstub.c
+++ b/target/i386/gdbstub.c
@@ -106,7 +106,7 @@ int x86_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n)
} else if (n >= IDX_FP_REGS && n < IDX_FP_REGS + 8) {
floatx80 *fp = (floatx80 *) &env->fpregs[n - IDX_FP_REGS];
int len = gdb_get_reg64(mem_buf, cpu_to_le64(fp->low));
- len += gdb_get_reg16(mem_buf + len, cpu_to_le16(fp->high));
+ len += gdb_get_reg16(mem_buf, cpu_to_le16(fp->high));
return len;
} else if (n >= IDX_XMM_REGS && n < IDX_XMM_REGS + CPU_NB_REGS) {
n -= IDX_XMM_REGS;
--
2.20.1
next prev parent reply other threads:[~2020-04-09 21:21 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 21:15 [PATCH for 5.0-rc3 v1 00/11] more random fixes Alex Bennée
2020-04-09 21:15 ` [PATCH v1 01/11] linux-user: completely re-write init_guest_space Alex Bennée
2020-04-09 21:15 ` [PATCH v1 02/11] exec/cpu-all: Use bool for have_guest_base Alex Bennée
2020-04-10 10:59 ` Philippe Mathieu-Daudé
2020-04-09 21:15 ` [PATCH v1 03/11] accel/tcg: Relax va restrictions on 64-bit guests Alex Bennée
2020-04-09 21:15 ` [PATCH v1 04/11] linux-user/ppc: Fix padding in mcontext_t for ppc64 Alex Bennée
2020-04-09 21:15 ` [PATCH v1 05/11] tests/docker: add docs FEATURE flag and use for test-misc Alex Bennée
2020-04-10 10:58 ` Philippe Mathieu-Daudé
2020-04-10 14:40 ` Richard Henderson
2020-04-09 21:15 ` [PATCH v1 06/11] configure: redirect sphinx-build check to config.log Alex Bennée
2020-04-10 10:56 ` Philippe Mathieu-Daudé
2020-04-10 14:37 ` Richard Henderson
2020-04-09 21:15 ` [PATCH v1 07/11] configure: disable PIE for Windows builds Alex Bennée
2020-04-09 21:15 ` [Bug 1871798] " Alex Bennée
2020-04-09 22:51 ` Howard Spoelstra
2020-04-09 22:51 ` [Bug 1871798] " Howard Spoelstra
2020-04-10 10:55 ` Philippe Mathieu-Daudé
2020-04-10 10:55 ` [Bug 1871798] " Philippe Mathieu-Daudé
2020-04-10 14:42 ` Richard Henderson
2020-04-09 21:15 ` [PATCH v1 08/11] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray Alex Bennée
2020-04-10 14:44 ` Richard Henderson
2020-04-09 21:15 ` Alex Bennée [this message]
2020-04-10 13:08 ` [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb Stefano Garzarella
2020-04-11 12:58 ` Alex Bennée
2020-04-14 7:48 ` Stefano Garzarella
2020-04-11 17:14 ` Philippe Mathieu-Daudé
2020-04-10 14:44 ` Richard Henderson
2020-04-09 21:15 ` [PATCH v1 10/11] linux-user: fix /proc/self/stat handling Alex Bennée
2020-04-10 11:11 ` Philippe Mathieu-Daudé
2020-04-10 12:33 ` Alex Bennée
2020-04-10 12:47 ` Philippe Mathieu-Daudé
2020-04-10 13:21 ` Brice Goglin
2020-04-11 13:00 ` Alex Bennée
2020-04-10 14:51 ` Richard Henderson
2020-04-09 21:15 ` [PATCH v1 11/11] .travis.yml: Build OSX 10.14 with Xcode 10.0 Alex Bennée
2020-04-14 10:17 ` Daniel P. Berrangé
2020-04-09 23:31 ` [PATCH for 5.0-rc3 v1 00/11] more random fixes no-reply
-- strict thread matches above, loose matches on Subject: below --
2020-04-15 10:42 [PULL for 5.0-rc3 0/8] a few small fixes (docker, user, pie and gdbstub) Alex Bennée
2020-04-15 10:42 ` [PULL 1/8] tests/docker: add docs FEATURE flag and use for test-misc Alex Bennée
2020-04-15 10:42 ` [PULL 2/8] configure: redirect sphinx-build check to config.log Alex Bennée
2020-04-15 10:42 ` [PULL 3/8] configure: disable PIE for Windows builds Alex Bennée
2020-04-15 10:42 ` [Bug 1871798] " Alex Bennée
2020-04-15 10:42 ` [PULL 4/8] linux-user: fix /proc/self/stat handling Alex Bennée
2020-04-15 10:42 ` [PULL 5/8] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray Alex Bennée
2020-04-15 10:42 ` [PULL 6/8] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb Alex Bennée
2020-04-15 10:42 ` [PULL 7/8] gdbstub: Do not use memset() on GByteArray Alex Bennée
2020-04-15 10:42 ` [PULL 8/8] gdbstub: Introduce gdb_get_float32() to get 32-bit float registers Alex Bennée
2020-04-15 12:16 ` [PULL for 5.0-rc3 0/8] a few small fixes (docker, user, pie and gdbstub) Peter Maydell
2020-04-14 20:06 [PATCH v2 for 5.0-rc3 00/17] more randome fixes (user, pie, docker " Alex Bennée
2020-04-14 20:06 ` [PATCH v2 01/17] linux-user: completely re-write init_guest_space Alex Bennée
2020-04-14 20:06 ` [PATCH v2 02/17] exec/cpu-all: Use bool for have_guest_base Alex Bennée
2020-04-14 20:06 ` [PATCH v2 03/17] accel/tcg: Relax va restrictions on 64-bit guests Alex Bennée
2020-04-14 20:06 ` [PATCH v2 04/17] .gitignore: include common build sub-directories Alex Bennée
2020-04-14 20:06 ` [PATCH v2 05/17] linux-user/ppc: Fix padding in mcontext_t for ppc64 Alex Bennée
2020-04-14 20:06 ` [PATCH v2 06/17] tests/docker: add docs FEATURE flag and use for test-misc Alex Bennée
2020-04-14 20:06 ` [PATCH v2 07/17] configure: redirect sphinx-build check to config.log Alex Bennée
2020-04-14 20:06 ` [PATCH v2 08/17] configure: disable PIE for Windows builds Alex Bennée
2020-04-14 20:06 ` [Bug 1871798] " Alex Bennée
2020-04-14 20:06 ` [PATCH v2 09/17] linux-user: fix /proc/self/stat handling Alex Bennée
2020-04-14 20:06 ` [PATCH v2 10/17] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray Alex Bennée
2020-04-14 20:06 ` [PATCH v2 11/17] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb Alex Bennée
2020-04-14 20:06 ` [PATCH v2 12/17] gdbstub: Do not use memset() on GByteArray Alex Bennée
2020-04-14 20:06 ` [PATCH v2 13/17] gdbstub: Introduce gdb_get_float32() to get 32-bit float registers Alex Bennée
2020-04-14 21:20 ` Richard Henderson
2020-04-14 20:06 ` [PATCH v2 14/17] gdbstub: Introduce gdb_get_float64() to get 64-bit " Alex Bennée
2020-04-14 21:22 ` Richard Henderson
2020-04-14 20:06 ` [PATCH v2 15/17] target/m68k: hack around the FPU register support (HACK!) Alex Bennée
2020-04-14 20:06 ` [PATCH v2 16/17] tests/tcg: drop inferior.was_attached() test Alex Bennée
2020-04-14 20:06 ` [PATCH v2 17/17] tests/tcg: add a multiarch linux-user gdb test Alex Bennée
2020-04-15 1:42 ` [PATCH v2 for 5.0-rc3 00/17] more randome fixes (user, pie, docker and gdbstub) no-reply
2020-04-09 8:43 [Bug 1871798] [NEW] Fails to start on Windows host without explicit --disable-pie James Le Cuirot
2020-04-09 8:51 ` [Bug 1871798] " Alex Bennée
2020-04-09 17:27 ` Alex Bennée
2020-04-09 18:39 ` James Le Cuirot
2020-04-09 19:31 ` James Le Cuirot
2020-04-09 23:04 ` James Le Cuirot
2020-04-18 13:41 ` Philippe Mathieu-Daudé
2020-04-30 13:45 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409211529.5269-10-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).