qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Raphael Norwitz <raphael.norwitz@nutanix.com>
To: mst@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Feature and message numbers missing in vhost-user.c
Date: Thu, 9 Apr 2020 20:41:15 -0400	[thread overview]
Message-ID: <20200410004115.GA7738@localhost.localdomain> (raw)

Hi MST,

I see that a new feature, VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS
(https://git.qemu.org/?p=qemu.git;a=blob;f=docs/interop/vhost-user.rst;h=3b1b6602c77932101e1e3b098e35c2497f5b0260;hb=HEAD#l817),
and corresponding VHOST_USER_VRING_KICK
(https://git.qemu.org/?p=qemu.git;a=blob;f=docs/interop/vhost-user.rst;h=3b1b6602c77932101e1e3b098e35c2497f5b0260;hb=HEAD#l1252)
message has been added to the documentation for the vhost-user protocol
and seem to be added in libvhost-user. However I don’t see the feature
or message number reserved in the core vhost-user code
(https://git.qemu.org/?p=qemu.git;a=blob;f=hw/virtio/vhost-user.c;h=08e7e63790e5bcfae6cd31bf9ccd32c3a7347f4e;hb=HEAD#l47)

I understand these features are mostly for simulation, but surely
the numbers for these features should at least be reserved as more
features and messages are frequently being added.

Is this an oversight? With the aim of preventing future confusion should
I send a patch to add them in /hw/virtio/vhost-user.c?

Thanks,
Raphael


                 reply	other threads:[~2020-04-10 12:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200410004115.GA7738@localhost.localdomain \
    --to=raphael.norwitz@nutanix.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).