* Feature and message numbers missing in vhost-user.c
@ 2020-04-10 0:41 Raphael Norwitz
0 siblings, 0 replies; only message in thread
From: Raphael Norwitz @ 2020-04-10 0:41 UTC (permalink / raw)
To: mst; +Cc: qemu-devel
Hi MST,
I see that a new feature, VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS
(https://git.qemu.org/?p=qemu.git;a=blob;f=docs/interop/vhost-user.rst;h=3b1b6602c77932101e1e3b098e35c2497f5b0260;hb=HEAD#l817),
and corresponding VHOST_USER_VRING_KICK
(https://git.qemu.org/?p=qemu.git;a=blob;f=docs/interop/vhost-user.rst;h=3b1b6602c77932101e1e3b098e35c2497f5b0260;hb=HEAD#l1252)
message has been added to the documentation for the vhost-user protocol
and seem to be added in libvhost-user. However I don’t see the feature
or message number reserved in the core vhost-user code
(https://git.qemu.org/?p=qemu.git;a=blob;f=hw/virtio/vhost-user.c;h=08e7e63790e5bcfae6cd31bf9ccd32c3a7347f4e;hb=HEAD#l47)
I understand these features are mostly for simulation, but surely
the numbers for these features should at least be reserved as more
features and messages are frequently being added.
Is this an oversight? With the aim of preventing future confusion should
I send a patch to add them in /hw/virtio/vhost-user.c?
Thanks,
Raphael
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-10 12:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-10 0:41 Feature and message numbers missing in vhost-user.c Raphael Norwitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).