qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>
Subject: [PULL 6/8] vl.c: error out if -mem-path is used together with -M memory-backend
Date: Sat, 11 Apr 2020 09:03:28 -0400	[thread overview]
Message-ID: <20200411130330.1993-7-pbonzini@redhat.com> (raw)
In-Reply-To: <20200411130330.1993-1-pbonzini@redhat.com>

From: Igor Mammedov <imammedo@redhat.com>

the former is not actually used by explicit backend, so instead of
silently ignoring the option in non valid context, exit with error.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20200409134133.11339-1-imammedo@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 softmmu/vl.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/softmmu/vl.c b/softmmu/vl.c
index 58a40bcfc1..32c0047889 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -4315,6 +4315,11 @@ void qemu_init(int argc, char **argv, char **envp)
                              "explicitly specified 'memory-backend' property");
                 exit(EXIT_FAILURE);
         }
+        if (mem_path) {
+            error_report("'-mem-path' can't be used together with"
+                         "'-machine memory-backend'");
+            exit(EXIT_FAILURE);
+        }
         ram_size = backend_size;
     }
 
-- 
2.18.2




  parent reply	other threads:[~2020-04-11 13:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-11 13:03 [PULL 0/8] Misc patches for QEMU 5.0-rc3 Paolo Bonzini
2020-04-11 13:03 ` [PULL 1/8] piix: fix xenfv regression, add compat machine xenfv-4.2 Paolo Bonzini
2020-04-11 13:03 ` [PULL 2/8] oslib-posix: take lock before qemu_cond_broadcast Paolo Bonzini
2020-04-11 13:03 ` [PULL 3/8] atomics: convert to reStructuredText Paolo Bonzini
2020-04-11 13:03 ` [PULL 4/8] atomics: update documentation Paolo Bonzini
2020-04-11 13:03 ` [PULL 5/8] rcu: do not mention atomic_mb_read/set in documentation Paolo Bonzini
2020-04-11 13:03 ` Paolo Bonzini [this message]
2020-04-11 13:03 ` [PULL 7/8] memory: Do not allow direct write access to rom_device regions Paolo Bonzini
2020-04-11 13:03 ` [PULL 8/8] module: increase dirs array size by one Paolo Bonzini
2020-04-11 16:54 ` [PULL 0/8] Misc patches for QEMU 5.0-rc3 Peter Maydell
2020-04-14  7:36 ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200411130330.1993-7-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).