From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Paul Burton" <pburton@wavecomp.com>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Jiri Slaby" <jslaby@suse.cz>,
"Li Zhijian" <lizhijian@cn.fujitsu.com>,
qemu-block@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Joel Stanley" <joel@jms.id.au>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Amit Shah" <amit@kernel.org>,
"Alistair Francis" <alistair@alistair23.me>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
"Cédric Le Goater" <clg@kaod.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
qemu-riscv@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Xiao Guangrong" <xiaoguangrong.eric@gmail.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Cornelia Huck" <cohuck@redhat.com>,
"Hailiang Zhang" <zhang.zhanghailiang@huawei.com>,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
"Max Reitz" <mreitz@redhat.com>,
"Zhang Chen" <chen.zhang@intel.com>,
qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH-for-5.1 v3 0/7] various: Fix error-propagation with Coccinelle scripts (part 3)
Date: Mon, 13 Apr 2020 00:45:10 +0200 [thread overview]
Message-ID: <20200412224517.12869-1-f4bug@amsat.org> (raw)
This series is inspired of Peter Maydell fix [1]:
"hw/arm/xlnx-zynqmp.c: fix some error-handling code",
but grew after v1 [2] review :/
Markus: I added the cocci patches to your Error section, I hope
that's fine :)
Part 3: Use &error_abort/&error_fatal in instance_init().
Regards,
Phil.
[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg691636.html
[2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg692155.html
Based-on: <20200412224144.12205-1-f4bug@amsat.org>
Philippe Mathieu-Daudé (7):
scripts/coccinelle: Use &error_abort in TypeInfo::instance_init()
various: Use &error_abort in instance_init()
scripts/coccinelle: Find eventually missing error_propagate() calls
migration/colo: Add missing error-propagation code
hw/mips/boston: Add missing error-propagation code
hw/mips/mips_malta: Use &error_abort in MachineClass::init ->
create_cps
qga/commands-win32: Add missing error-propagation code
.../find-missing-error_propagate.cocci | 53 +++++++++++++++++++
.../use-error_abort-in-instance_init.cocci | 45 ++++++++++++++++
backends/cryptodev-vhost-user.c | 2 +-
backends/rng-egd.c | 2 +-
backends/rng-random.c | 2 +-
backends/vhost-user.c | 3 +-
hw/arm/bcm2835_peripherals.c | 6 ++-
hw/arm/vexpress.c | 8 +--
hw/arm/xlnx-zcu102.c | 8 +--
hw/block/fdc.c | 4 +-
hw/block/vhost-user-blk.c | 2 +-
hw/block/virtio-blk.c | 2 +-
hw/core/machine.c | 6 +--
hw/cpu/core.c | 4 +-
hw/display/vga-pci.c | 7 ++-
hw/display/xlnx_dp.c | 4 +-
hw/dma/sparc32_dma.c | 2 +-
hw/gpio/aspeed_gpio.c | 2 +-
hw/ide/macio.c | 4 +-
hw/ide/qdev.c | 4 +-
hw/intc/apic_common.c | 2 +-
hw/mem/nvdimm.c | 4 +-
hw/mips/boston.c | 17 +++---
hw/mips/mips_malta.c | 15 ++----
hw/misc/aspeed_sdmc.c | 2 +-
hw/misc/edu.c | 3 +-
hw/misc/macio/macio.c | 4 +-
hw/misc/macio/pmu.c | 3 +-
hw/misc/pca9552.c | 2 +-
hw/misc/tmp105.c | 2 +-
hw/misc/tmp421.c | 8 +--
hw/net/e1000.c | 3 +-
hw/net/lance.c | 3 +-
hw/net/lasi_i82596.c | 3 +-
hw/net/ne2000-isa.c | 4 +-
hw/net/spapr_llan.c | 3 +-
hw/net/virtio-net.c | 2 +-
hw/pci-host/grackle.c | 2 +-
hw/pci-host/i440fx.c | 8 +--
hw/pci-host/prep.c | 2 +-
hw/pci-host/q35.c | 23 ++++----
hw/pci-host/sabre.c | 3 +-
hw/pci-host/uninorth.c | 9 ++--
hw/pcmcia/pxa2xx.c | 3 +-
hw/ppc/spapr_drc.c | 6 +--
hw/ppc/spapr_rng.c | 2 +-
hw/riscv/sifive_u.c | 4 +-
hw/s390x/event-facility.c | 6 +--
hw/s390x/s390-ccw.c | 2 +-
hw/s390x/s390-skeys.c | 4 +-
hw/s390x/s390-stattrib.c | 4 +-
hw/s390x/sclp.c | 2 +-
hw/scsi/scsi-bus.c | 2 +-
hw/ssi/xilinx_spips.c | 2 +-
hw/usb/bus.c | 4 +-
hw/usb/dev-network.c | 2 +-
hw/usb/dev-storage.c | 4 +-
hw/usb/host-libusb.c | 2 +-
hw/usb/redirect.c | 2 +-
hw/virtio/virtio-balloon.c | 4 +-
migration/colo.c | 3 ++
net/dump.c | 4 +-
net/filter-buffer.c | 2 +-
net/filter-mirror.c | 10 ++--
net/filter-rewriter.c | 3 +-
qga/commands-win32.c | 26 ++++++---
target/arm/cpu64.c | 4 +-
target/i386/cpu.c | 23 ++++----
target/s390x/cpu.c | 3 +-
tests/check-qom-proplist.c | 7 +--
tests/test-qdev-global-props.c | 5 +-
MAINTAINERS | 2 +
72 files changed, 289 insertions(+), 155 deletions(-)
create mode 100644 scripts/coccinelle/find-missing-error_propagate.cocci
create mode 100644 scripts/coccinelle/use-error_abort-in-instance_init.cocci
--
2.21.1
reply other threads:[~2020-04-12 23:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200412224517.12869-1-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=Andrew.Baumann@microsoft.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=alistair@alistair23.me \
--cc=amit@kernel.org \
--cc=andrew@aj.id.au \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=chen.zhang@intel.com \
--cc=clg@kaod.org \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=hpoussin@reactos.org \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=jslaby@suse.cz \
--cc=jsnow@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=lvivier@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pburton@wavecomp.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).