* [PATCH] hw/rdma: Destroy list mutex when list is destroyed
@ 2020-04-13 8:57 Yuval Shaia
2020-04-14 8:09 ` Marcel Apfelbaum
0 siblings, 1 reply; 2+ messages in thread
From: Yuval Shaia @ 2020-04-13 8:57 UTC (permalink / raw)
To: qemu-devel, yuval.shaia.ml, marcel.apfelbaum; +Cc: Peter Maydell
List mutex should be destroyed when gs list gets destroyed.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
---
hw/rdma/rdma_utils.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/rdma/rdma_utils.c b/hw/rdma/rdma_utils.c
index 73f279104c..698ed4716c 100644
--- a/hw/rdma/rdma_utils.c
+++ b/hw/rdma/rdma_utils.c
@@ -100,6 +100,7 @@ void rdma_protected_gslist_destroy(RdmaProtectedGSList *list)
{
if (list->list) {
g_slist_free(list->list);
+ qemu_mutex_destroy(&list->lock);
list->list = NULL;
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hw/rdma: Destroy list mutex when list is destroyed
2020-04-13 8:57 [PATCH] hw/rdma: Destroy list mutex when list is destroyed Yuval Shaia
@ 2020-04-14 8:09 ` Marcel Apfelbaum
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Apfelbaum @ 2020-04-14 8:09 UTC (permalink / raw)
To: Yuval Shaia, qemu-devel; +Cc: Peter Maydell
Hi Yuval,
On 4/13/20 11:57 AM, Yuval Shaia wrote:
> List mutex should be destroyed when gs list gets destroyed.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
> ---
> hw/rdma/rdma_utils.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/rdma/rdma_utils.c b/hw/rdma/rdma_utils.c
> index 73f279104c..698ed4716c 100644
> --- a/hw/rdma/rdma_utils.c
> +++ b/hw/rdma/rdma_utils.c
> @@ -100,6 +100,7 @@ void rdma_protected_gslist_destroy(RdmaProtectedGSList *list)
> {
> if (list->list) {
> g_slist_free(list->list);
> + qemu_mutex_destroy(&list->lock);
> list->list = NULL;
> }
> }
Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>
Thanks,
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-14 8:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-13 8:57 [PATCH] hw/rdma: Destroy list mutex when list is destroyed Yuval Shaia
2020-04-14 8:09 ` Marcel Apfelbaum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).