qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: qemu-block@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Beata Michalska" <beata.michalska@linaro.org>,
	"Klaus Jensen" <k.jensen@samsung.com>,
	qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Keith Busch" <kbusch@kernel.org>,
	"Javier Gonzalez" <javier.gonz@samsung.com>,
	"Maxim Levitsky" <mlevitsk@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH 01/16] nvme: fix pci doorbell size calculation
Date: Wed, 15 Apr 2020 12:24:30 +0200	[thread overview]
Message-ID: <20200415102445.564803-2-its@irrelevant.dk> (raw)
In-Reply-To: <20200415102445.564803-1-its@irrelevant.dk>

From: Klaus Jensen <k.jensen@samsung.com>

The size of the BAR is 0x1000 (main registers) + 8 bytes for each
queue. Currently, the size of the BAR is calculated like so:

    n->reg_size = pow2ceil(0x1004 + 2 * (n->params.num_queues + 1) * 4);

Since the 'num_queues' parameter already accounts for the admin queue,
this should in any case not need to be incremented by one. Also, the
size should be initialized to (0x1000).

    n->reg_size = pow2ceil(0x1000 + 2 * n->params.num_queues * 4);

This, with the default value of num_queues (64), we will set aside room
for 1 admin queue and 63 I/O queues (4 bytes per doorbell, 2 doorbells
per queue).

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
 hw/block/nvme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index d28335cbf377..77f9c151a665 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1345,7 +1345,7 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp)
     pcie_endpoint_cap_init(pci_dev, 0x80);
 
     n->num_namespaces = 1;
-    n->reg_size = pow2ceil(0x1004 + 2 * (n->num_queues + 1) * 4);
+    n->reg_size = pow2ceil(0x1000 + 2 * n->num_queues * 4);
     n->ns_size = bs_size / (uint64_t)n->num_namespaces;
 
     n->namespaces = g_new0(NvmeNamespace, n->num_namespaces);
-- 
2.26.0



  reply	other threads:[~2020-04-15 10:26 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 10:24 [PATCH 00/16] nvme: refactoring and cleanups Klaus Jensen
2020-04-15 10:24 ` Klaus Jensen [this message]
2020-04-15 11:34   ` [PATCH 01/16] nvme: fix pci doorbell size calculation Philippe Mathieu-Daudé
2020-04-15 10:24 ` [PATCH 02/16] nvme: rename trace events to nvme_dev Klaus Jensen
2020-04-15 11:36   ` Philippe Mathieu-Daudé
2020-04-15 10:24 ` [PATCH 03/16] nvme: remove superfluous breaks Klaus Jensen
2020-04-15 10:24 ` [PATCH 04/16] nvme: move device parameters to separate struct Klaus Jensen
2020-04-15 10:24 ` [PATCH 05/16] nvme: use constants in identify Klaus Jensen
2020-04-15 10:24 ` [PATCH 06/16] nvme: refactor nvme_addr_read Klaus Jensen
2020-04-15 10:24 ` [PATCH 07/16] nvme: add max_ioqpairs device parameter Klaus Jensen
2020-04-15 11:02   ` Philippe Mathieu-Daudé
2020-04-15 10:24 ` [PATCH 08/16] nvme: remove redundant cmbloc/cmbsz members Klaus Jensen
2020-04-15 10:24 ` [PATCH 09/16] nvme: factor out property/constraint checks Klaus Jensen
2020-04-15 10:56   ` Philippe Mathieu-Daudé
2020-04-15 10:24 ` [PATCH 10/16] nvme: factor out device state setup Klaus Jensen
2020-04-15 10:54   ` Philippe Mathieu-Daudé
2020-04-15 10:24 ` [PATCH 11/16] nvme: factor out block backend setup Klaus Jensen
2020-04-15 10:52   ` Philippe Mathieu-Daudé
2020-04-15 11:02     ` Klaus Birkelund Jensen
2020-04-15 11:21       ` Klaus Birkelund Jensen
2020-04-15 10:24 ` [PATCH 12/16] nvme: add namespace helpers Klaus Jensen
2020-04-15 10:36   ` Philippe Mathieu-Daudé
2020-04-15 10:24 ` [PATCH 13/16] nvme: factor out namespace setup Klaus Jensen
2020-04-15 10:38   ` Philippe Mathieu-Daudé
2020-04-15 10:53     ` Klaus Birkelund Jensen
2020-04-15 10:59       ` Klaus Birkelund Jensen
2020-04-15 10:24 ` [PATCH 14/16] nvme: factor out pci setup Klaus Jensen
2020-04-15 10:43   ` Philippe Mathieu-Daudé
2020-04-15 10:24 ` [PATCH 15/16] nvme: factor out cmb setup Klaus Jensen
2020-04-15 10:45   ` Philippe Mathieu-Daudé
2020-04-15 10:24 ` [PATCH 16/16] nvme: factor out controller identify setup Klaus Jensen
2020-04-15 11:07   ` Philippe Mathieu-Daudé
2020-04-15 13:35 ` [PATCH 00/16] nvme: refactoring and cleanups no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200415102445.564803-2-its@irrelevant.dk \
    --to=its@irrelevant.dk \
    --cc=beata.michalska@linaro.org \
    --cc=javier.gonz@samsung.com \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kwolf@redhat.com \
    --cc=mlevitsk@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).