From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A806C2BB55 for ; Wed, 15 Apr 2020 10:44:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 098C5206F9 for ; Wed, 15 Apr 2020 10:44:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bXs6vLnL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 098C5206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOfXE-0007Db-5C for qemu-devel@archiver.kernel.org; Wed, 15 Apr 2020 06:44:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45472) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOfUp-00029R-K9 for qemu-devel@nongnu.org; Wed, 15 Apr 2020 06:42:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOfUo-00037T-Fl for qemu-devel@nongnu.org; Wed, 15 Apr 2020 06:42:19 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:51866) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOfUo-00037D-9m for qemu-devel@nongnu.org; Wed, 15 Apr 2020 06:42:18 -0400 Received: by mail-wm1-x336.google.com with SMTP id x4so16843604wmj.1 for ; Wed, 15 Apr 2020 03:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R1iGbNrPxs7Q1flfCK5WZAyghUVesN3d6e9WvcQ4hxE=; b=bXs6vLnL1mmwCoZunbo4QOPJgBB3Nr1b5K1QpKfcOt80TgynDurUml9i13rYBUdXjj RASNv6rnVvK8gfMGDvxwRjvqRcsbrJbiiCYKWxnW6AaE++dtX/thhAN/lKblFkhQirUd 4VAr331f1TmVHcOhFeu87JdpbTeJxGLVcjWgjQUI+Olr4LLbeylbwm+lZefPk8hNfs8o 58uZFDax1ppAvQXI7htmHuGH1BOg+4RIyv2BB9uDvk9L8hSQJSYW6CnPia+ZhEU4fzBi vK4Aby+fer7RBNuTaSLQYKXLppuMBVH+eN0v0dWDP7XK/pMCnCKtER1ZBWfryudDleh6 NPhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R1iGbNrPxs7Q1flfCK5WZAyghUVesN3d6e9WvcQ4hxE=; b=IBZSOS3dDCNhIzvu0VfEVpjoEEkjiho7HOVWoHjMqbtIecVR0WkPfyrlkcQ9i4Xhnw 6KG+AJ+Pf1kVnQlhTjSdTt81e8ejXM45YbON9SGO+7utnsKdz6x92WBIrS10ZmYZwjAY llBWR+cFcgFm+NlbiThzLEjNiz1FvTyv4lgOgabqYKoJucJbwNO3QIEnvE6OpsAbkrrH EOpRGfgd7IdccHGh5HuenFPkmVS2e3lfSGte5iXPKe9pIiMvJlc8G6CmnNhAeIn307+U dABlWGpgDXD7FWcY8oe8ALdd7RVtS4092yYtYyLC7rslJVbQCRLco5D3CihqAdJCe9kZ Bhfg== X-Gm-Message-State: AGi0PuaGExaLSE3344w90ePm/xOIqQZKrpWObWou03YNJVmPuwDYkdAV YD8RGhXwE+urY5iXLEJHfFUdJw== X-Google-Smtp-Source: APiQypKb/M6xge/q/yD5nbz1LzCSXm33CHkFr7YucYOpdg6FuCG/mOppP/+hsqsrFCoK6Xwrc+vmhA== X-Received: by 2002:a1c:6503:: with SMTP id z3mr4759100wmb.92.1586947337330; Wed, 15 Apr 2020 03:42:17 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id e15sm22831332wrt.16.2020.04.15.03.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 03:42:12 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 416D21FF8F; Wed, 15 Apr 2020 11:42:12 +0100 (BST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 3/8] configure: disable PIE for Windows builds Date: Wed, 15 Apr 2020 11:42:06 +0100 Message-Id: <20200415104211.9388-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200415104211.9388-1-alex.bennee@linaro.org> References: <20200415104211.9388-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::336 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bug 1871798 <1871798@bugs.launchpad.net>, Richard Henderson , qemu-devel@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , James Le Cuirot , Howard Spoelstra , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" It seems on some compilers the test can pass but still give you broken binaries. Fixes: d2cd29e30736 Fixes: https://bugs.launchpad.net/qemu/+bug/1871798 Cc: Bug 1871798 <1871798@bugs.launchpad.net> Signed-off-by: Alex Bennée Tested-by: Howard Spoelstra Tested-by: James Le Cuirot Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200414200631.12799-9-alex.bennee@linaro.org> diff --git a/configure b/configure index 25f7d915720..23b5e93752b 100755 --- a/configure +++ b/configure @@ -807,6 +807,7 @@ MINGW32*) audio_drv_list="" fi supported_os="yes" + pie="no" ;; GNU/kFreeBSD) bsd="yes" -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C9CAC2BA19 for ; Wed, 15 Apr 2020 10:51:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3055520737 for ; Wed, 15 Apr 2020 10:51:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3055520737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOfe0-0007i4-Dh for qemu-devel@archiver.kernel.org; Wed, 15 Apr 2020 06:51:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46941) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOfdT-0007Gd-Ji for qemu-devel@nongnu.org; Wed, 15 Apr 2020 06:51:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOfdS-0003N3-Fa for qemu-devel@nongnu.org; Wed, 15 Apr 2020 06:51:15 -0400 Received: from indium.canonical.com ([91.189.90.7]:38564) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOfdS-0003Ly-AX for qemu-devel@nongnu.org; Wed, 15 Apr 2020 06:51:14 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1jOfdR-0000YT-0n for ; Wed, 15 Apr 2020 10:51:13 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id CD1E12E8109 for ; Wed, 15 Apr 2020 10:51:12 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Wed, 15 Apr 2020 10:42:06 -0000 From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=Incomplete; importance=Undecided; assignee=None; X-Launchpad-Bug-Tags: configure pie windows X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: ajbennee cat-7 chewi philmd X-Launchpad-Bug-Reporter: James Le Cuirot (chewi) X-Launchpad-Bug-Modifier: =?utf-8?q?Alex_Benn=C3=A9e_=28ajbennee=29?= References: <158642182265.5805.199845175533907355.malonedeb@chaenomeles.canonical.com> Message-Id: <20200415104211.9388-4-alex.bennee@linaro.org> Subject: [Bug 1871798] [PULL 3/8] configure: disable PIE for Windows builds X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="2e26c9bbd21cdca248baaea29aeffb920afcc32a"; Instance="production-secrets-lazr.conf" X-Launchpad-Hash: f294c8bc4943d2cfc8eb63a82b99486d0c7f5f2d X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 91.189.90.7 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1871798 <1871798@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20200415104206.GFTD8NX0ry2t-0RDgLyvMkXVrRm-uPHXrn17smgXk0k@z> It seems on some compilers the test can pass but still give you broken binaries. Fixes: d2cd29e30736 Fixes: https://bugs.launchpad.net/qemu/+bug/1871798 Cc: Bug 1871798 <1871798@bugs.launchpad.net> Signed-off-by: Alex Benn=C3=A9e Tested-by: Howard Spoelstra Tested-by: James Le Cuirot Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20200414200631.12799-9-alex.bennee@linaro.org> diff --git a/configure b/configure index 25f7d915720..23b5e93752b 100755 --- a/configure +++ b/configure @@ -807,6 +807,7 @@ MINGW32*) audio_drv_list=3D"" fi supported_os=3D"yes" + pie=3D"no" ;; GNU/kFreeBSD) bsd=3D"yes" -- = 2.20.1 -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1871798 Title: Fails to start on Windows host without explicit --disable-pie Status in QEMU: Incomplete Bug description: Since commit d2cd29e30736afd4a1e8cac3cf4da360bbc65978, which removed the x86 conditional around PIE, QEMU completely fails to start on a Windows host unless --disable-pie is explicitly given at build time. Even just requesting the help text doesn't work. To make testing easier, this can be replicated with Wine. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1871798/+subscriptions