From: ni.xun.intel@gmail.com
To: raphael.norwitz@nutanix.com, mst@redhat.com, kwolf@redhat.com,
mreitz@redhat.com, qemu-block@nongnu.org
Cc: Yan Miao <leomyan@tencent.com>, lucascye <lucascye@tencent.com>,
Lu Zhigang <tonnylu@tencent.com>,
qemu-devel@nongnu.org, Ni Xun <richardni@tencent.com>
Subject: [PATCH] resend slave fd to vhost when reconnect to vhost
Date: Fri, 17 Apr 2020 13:14:00 +0800 [thread overview]
Message-ID: <20200417051400.30398-1-richardni@tencent.com> (raw)
From: Ni Xun <richardni@tencent.com>
when reconnecting to vhost server, it doesn't send slave fd to vhost
as the slave fd is only sent in vhost_user_init. also resend the slave fd
in vhost reconnect.
Signed-off-by: Ni Xun <richardni@tencent.com>
Signed-off-by: Lu Zhigang <tonnylu@tencent.com>
Signed-off-by: Yan Miao <leomyan@tencent.com>
Signed-off-by: lucascye <lucascye@tencent.com>
---
hw/block/vhost-user-blk.c | 6 ++++++
hw/virtio/vhost-user.c | 2 +-
include/hw/virtio/vhost.h | 1 +
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
index 17df5338e7..59650a570b 100644
--- a/hw/block/vhost-user-blk.c
+++ b/hw/block/vhost-user-blk.c
@@ -138,6 +138,12 @@ static int vhost_user_blk_start(VirtIODevice *vdev)
error_report("Error get inflight: %d", -ret);
goto err_guest_notifiers;
}
+ } else {
+ ret = vhost_setup_slave_channel(&s->dev);
+ if (ret < 0) {
+ error_report("Error setting vhost slave channel: %d", -ret);
+ return ret;
+ }
}
ret = vhost_dev_set_inflight(&s->dev, s->inflight);
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 08e7e63790..0da4a12787 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -1115,7 +1115,7 @@ err:
return;
}
-static int vhost_setup_slave_channel(struct vhost_dev *dev)
+int vhost_setup_slave_channel(struct vhost_dev *dev)
{
VhostUserMsg msg = {
.hdr.request = VHOST_USER_SET_SLAVE_REQ_FD,
diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h
index 085450c6f8..cad60ad521 100644
--- a/include/hw/virtio/vhost.h
+++ b/include/hw/virtio/vhost.h
@@ -100,6 +100,7 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev);
void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev);
int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev);
void vhost_dev_disable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev);
+int vhost_setup_slave_channel(struct vhost_dev *hdev);
/* Test and clear masked event pending status.
* Should be called after unmask to avoid losing events.
--
2.24.1 (Apple Git-126)
next reply other threads:[~2020-04-17 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 5:14 ni.xun.intel [this message]
2020-04-14 10:02 ` [PATCH] resend slave fd to vhost when reconnect to vhost Raphael Norwitz
2020-04-18 10:42 ` xun ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417051400.30398-1-richardni@tencent.com \
--to=ni.xun.intel@gmail.com \
--cc=kwolf@redhat.com \
--cc=leomyan@tencent.com \
--cc=lucascye@tencent.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=richardni@tencent.com \
--cc=tonnylu@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).