From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
qemu-ppc@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
"Dennis Clarke" <dclarke@blastwave.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia()
Date: Fri, 17 Apr 2020 11:07:49 +0200 [thread overview]
Message-ID: <20200417090749.14310-1-f4bug@amsat.org> (raw)
This fixes:
$ qemu-system-ppc64 \
-machine pseries-4.1 -cpu power9 \
-smp 4 -m 12G -accel tcg ...
...
Quiescing Open Firmware ...
Booting Linux via __start() @ 0x0000000002000000 ...
Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
[*] https://www.mail-archive.com/qemu-discuss@nongnu.org/msg05400.html
Fixes: 0418bf78fe8 ("Fix ISA v3.0 (POWER9) slbia implementation")
Reported-by: Dennis Clarke <dclarke@blastwave.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/ppc/translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index b207fb5386..0136c7e3ff 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -5003,6 +5003,7 @@ static void gen_slbia(DisasContext *ctx)
CHK_SV;
gen_helper_slbia(cpu_env, t0);
+ tcg_temp_free_i32(t0);
#endif /* defined(CONFIG_USER_ONLY) */
}
--
2.21.1
next reply other threads:[~2020-04-17 9:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 9:07 Philippe Mathieu-Daudé [this message]
2020-04-17 10:51 ` [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia() Nicholas Piggin
2020-04-17 11:00 ` Philippe Mathieu-Daudé
2020-04-18 10:45 ` Nicholas Piggin
2020-04-17 12:46 ` Cédric Le Goater
2020-04-20 18:56 ` Peter Maydell
2020-04-20 22:53 ` Dennis Clarke
2020-04-21 0:49 ` David Gibson
2020-04-21 7:17 ` Philippe Mathieu-Daudé
2020-04-21 16:07 ` Dennis Clarke
2020-04-21 0:31 ` David Gibson
2020-04-21 9:29 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417090749.14310-1-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=dclarke@blastwave.org \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).