From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Luc Michel <luc.michel@greensocs.com>
Cc: figlesia@xilinx.com, peter.maydell@linaro.org,
sstabellini@kernel.org, sai.pavan.boddu@xilinx.com,
frasse.iglesias@gmail.com, alistair@alistair23.me,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
frederic.konrad@adacore.com,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
philmd@redhat.com
Subject: Re: [PATCH v1 3/6] target/microblaze: Add the div-zero-exception property
Date: Mon, 20 Apr 2020 19:20:50 +0200 [thread overview]
Message-ID: <20200420172050.GR4289@toto> (raw)
In-Reply-To: <ec41d1a0-10d1-0c37-9e71-32103f9d6b1e@greensocs.com>
On Sun, Apr 19, 2020 at 09:25:28PM +0200, Luc Michel wrote:
> Hi Edgar,
>
> On 4/17/20 9:10 PM, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> >
> > Add the div-zero-exception property to control if the core
> > traps divizions by zero.
> >
> > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > ---
...
> > }
> >
>
> I don't know the Microblaze but don't you need to set pvr.regs[2] in
> mb_cpu_realizefn as you do in previous patches?
>
> Something like:
>
> env->pvr.regs[2] |=
> ...
> (cpu->cfg.div_zero_exception ?
> PVR2_DIV_ZERO_EXC_MASK : 0) |
> ...
Yes you're right Luc. I'll post a v2 shortly.
Thanks,
Edgar
next prev parent reply other threads:[~2020-04-20 17:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 19:10 [PATCH v1 0/6] target-microblaze: Misc configurability #2 Edgar E. Iglesias
2020-04-17 19:10 ` [PATCH v1 1/6] target/microblaze: Add the opcode-0x0-illegal CPU property Edgar E. Iglesias
2020-04-17 21:30 ` Alistair Francis
2020-04-19 19:07 ` Luc Michel
2020-04-17 19:10 ` [PATCH v1 2/6] target/microblaze: Add the ill-opcode-exception property Edgar E. Iglesias
2020-04-17 21:31 ` Alistair Francis
2020-04-19 19:08 ` Luc Michel
2020-04-17 19:10 ` [PATCH v1 3/6] target/microblaze: Add the div-zero-exception property Edgar E. Iglesias
2020-04-17 21:35 ` Alistair Francis
2020-04-19 19:25 ` Luc Michel
2020-04-20 17:20 ` Edgar E. Iglesias [this message]
2020-04-17 19:10 ` [PATCH v1 4/6] target/microblaze: Add the unaligned-exceptions property Edgar E. Iglesias
2020-04-17 21:35 ` Alistair Francis
2020-04-19 19:26 ` Luc Michel
2020-04-17 19:10 ` [PATCH v1 5/6] target/microblaze: Add the pvr-user1 property Edgar E. Iglesias
2020-04-17 21:36 ` Alistair Francis
2020-04-19 19:28 ` Luc Michel
2020-04-17 19:10 ` [PATCH v1 6/6] target/microblaze: Add the pvr-user2 property Edgar E. Iglesias
2020-04-17 21:36 ` Alistair Francis
2020-04-19 19:30 ` Luc Michel
2020-04-17 23:42 ` [PATCH v1 0/6] target-microblaze: Misc configurability #2 no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420172050.GR4289@toto \
--to=edgar.iglesias@xilinx.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=figlesia@xilinx.com \
--cc=frasse.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=luc.michel@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).