From: Eduardo Habkost <ehabkost@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: peter.maydell@linaro.org, qemu-trivial@nongnu.org,
qemu-devel@nongnu.org,
"open list:X86 HAXM CPUs" <haxm-team@intel.com>,
Colin Xu <colin.xu@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Wenchao Wang <wenchao.wang@intel.com>
Subject: Re: [PATCH 1/2] hax: Fix setting of FD_CLOEXEC
Date: Mon, 20 Apr 2020 18:07:33 -0400 [thread overview]
Message-ID: <20200420220733.GH4952@habkost.net> (raw)
In-Reply-To: <20200420175309.75894-2-eblake@redhat.com>
On Mon, Apr 20, 2020 at 12:53:07PM -0500, Eric Blake wrote:
> Blindly setting FD_CLOEXEC without a read-modify-write will
> inadvertently clear any other intentionally-set bits, such as a
> proposed new bit for designating a fd that must behave in 32-bit mode.
> Use our wrapper function instead of an incorrect hand-rolled version.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Thanks, queued for 5.1.
--
Eduardo
next prev parent reply other threads:[~2020-04-20 22:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 17:53 [PATCH 0/2] fix fcntl(F_SETFD) usage Eric Blake
2020-04-20 17:53 ` [PATCH 1/2] hax: Fix setting of FD_CLOEXEC Eric Blake
2020-04-20 22:07 ` Eduardo Habkost [this message]
2020-06-02 17:47 ` Eric Blake
2020-04-21 1:22 ` Colin Xu
2020-04-20 17:53 ` [PATCH 2/2] tools: Fix use of fcntl(F_SETFD) during socket activation Eric Blake
2020-04-21 21:46 ` Eric Blake
2020-04-20 19:10 ` [PATCH 0/2] fix fcntl(F_SETFD) usage Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420220733.GH4952@habkost.net \
--to=ehabkost@redhat.com \
--cc=colin.xu@intel.com \
--cc=eblake@redhat.com \
--cc=haxm-team@intel.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=wenchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).