From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>,
qemu-trivial@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v3 2/9] blockdev: Remove dead assignment
Date: Wed, 22 Apr 2020 15:31:45 +0200 [thread overview]
Message-ID: <20200422133152.16770-3-philmd@redhat.com> (raw)
In-Reply-To: <20200422133152.16770-1-philmd@redhat.com>
Fix warning reported by Clang static code analyzer:
CC blockdev.o
blockdev.c:2744:5: warning: Value stored to 'ret' is never read
ret = blk_truncate(blk, size, false, PREALLOC_MODE_OFF, errp);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
blockdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index fa8630cb41..6effd5afaa 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2741,7 +2741,7 @@ void qmp_block_resize(bool has_device, const char *device,
}
bdrv_drained_begin(bs);
- ret = blk_truncate(blk, size, false, PREALLOC_MODE_OFF, errp);
+ blk_truncate(blk, size, false, PREALLOC_MODE_OFF, errp);
bdrv_drained_end(bs);
out:
--
2.21.1
next prev parent reply other threads:[~2020-04-22 13:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 13:31 [PATCH v3 0/9] misc: Trivial static code analyzer fixes Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 1/9] block: Avoid dead assignment Philippe Mathieu-Daudé
2020-04-23 18:11 ` Max Reitz
2020-04-22 13:31 ` Philippe Mathieu-Daudé [this message]
2020-04-23 18:11 ` [PATCH v3 2/9] blockdev: Remove " Max Reitz
2020-04-22 13:31 ` [PATCH v3 3/9] hw/i2c/pm_smbus: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 4/9] hw/input/adb-kbd: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 5/9] hw/ide/sii3112: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 6/9] hw/isa/i82378: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 7/9] hw/gpio/aspeed_gpio: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 8/9] hw/timer/stm32f2xx_timer: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 9/9] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning Philippe Mathieu-Daudé
2020-05-04 8:55 ` [PATCH v3 0/9] misc: Trivial static code analyzer fixes Philippe Mathieu-Daudé
2020-05-04 10:04 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422133152.16770-3-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).