From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"open list:Old World g3beige" <qemu-ppc@nongnu.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH v3 4/9] hw/input/adb-kbd: Remove dead assignment
Date: Wed, 22 Apr 2020 15:31:47 +0200 [thread overview]
Message-ID: <20200422133152.16770-5-philmd@redhat.com> (raw)
In-Reply-To: <20200422133152.16770-1-philmd@redhat.com>
Since commit 5a1f49718 the 'olen' variable is not really
used. Remove it to fix a warning reported by Clang static
code analyzer:
CC hw/input/adb-kbd.o
hw/input/adb-kbd.c:200:5: warning: Value stored to 'olen' is never read
olen = 0;
^ ~
Fixes: 5a1f49718 (adb: add support for QKeyCode)
Reported-by: Clang Static Analyzer
Suggested-by: BALATON Zoltan <balaton@eik.bme.hu>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/input/adb-kbd.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/input/adb-kbd.c b/hw/input/adb-kbd.c
index 0ba8207589..a6d5c9b7c9 100644
--- a/hw/input/adb-kbd.c
+++ b/hw/input/adb-kbd.c
@@ -195,9 +195,7 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf)
{
KBDState *s = ADB_KEYBOARD(d);
int keycode;
- int olen;
- olen = 0;
if (s->count == 0) {
return 0;
}
@@ -216,7 +214,6 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf)
if (keycode == 0x7f) {
obuf[0] = 0x7f;
obuf[1] = 0x7f;
- olen = 2;
} else {
obuf[0] = keycode;
/* NOTE: the power key key-up is the two byte sequence 0xff 0xff;
@@ -224,10 +221,9 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf)
* byte, but choose not to bother.
*/
obuf[1] = 0xff;
- olen = 2;
}
- return olen;
+ return 2;
}
static int adb_kbd_request(ADBDevice *d, uint8_t *obuf,
--
2.21.1
next prev parent reply other threads:[~2020-04-22 13:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 13:31 [PATCH v3 0/9] misc: Trivial static code analyzer fixes Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 1/9] block: Avoid dead assignment Philippe Mathieu-Daudé
2020-04-23 18:11 ` Max Reitz
2020-04-22 13:31 ` [PATCH v3 2/9] blockdev: Remove " Philippe Mathieu-Daudé
2020-04-23 18:11 ` Max Reitz
2020-04-22 13:31 ` [PATCH v3 3/9] hw/i2c/pm_smbus: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` Philippe Mathieu-Daudé [this message]
2020-04-22 13:31 ` [PATCH v3 5/9] hw/ide/sii3112: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 6/9] hw/isa/i82378: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 7/9] hw/gpio/aspeed_gpio: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 8/9] hw/timer/stm32f2xx_timer: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 9/9] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning Philippe Mathieu-Daudé
2020-05-04 8:55 ` [PATCH v3 0/9] misc: Trivial static code analyzer fixes Philippe Mathieu-Daudé
2020-05-04 10:04 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422133152.16770-5-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).