qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "open list:IDE" <qemu-block@nongnu.org>,
	qemu-trivial@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"open list:sam460ex" <qemu-ppc@nongnu.org>,
	"John Snow" <jsnow@redhat.com>
Subject: [PATCH v3 5/9] hw/ide/sii3112: Remove dead assignment
Date: Wed, 22 Apr 2020 15:31:48 +0200	[thread overview]
Message-ID: <20200422133152.16770-6-philmd@redhat.com> (raw)
In-Reply-To: <20200422133152.16770-1-philmd@redhat.com>

Fix warning reported by Clang static code analyzer:

    CC      hw/ide/sii3112.o
  hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read
          val = 0;
          ^     ~

Fixes: a9dd6604
Reported-by: Clang Static Analyzer
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/ide/sii3112.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c
index d69079c3d9..94d2b57f95 100644
--- a/hw/ide/sii3112.c
+++ b/hw/ide/sii3112.c
@@ -42,7 +42,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr addr,
                                 unsigned int size)
 {
     SiI3112PCIState *d = opaque;
-    uint64_t val = 0;
+    uint64_t val;
 
     switch (addr) {
     case 0x00:
@@ -126,6 +126,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr addr,
         break;
     default:
         val = 0;
+        break;
     }
     trace_sii3112_read(size, addr, val);
     return val;
@@ -201,7 +202,7 @@ static void sii3112_reg_write(void *opaque, hwaddr addr,
         d->regs[1].sien = (val >> 16) & 0x3eed;
         break;
     default:
-        val = 0;
+        break;
     }
 }
 
-- 
2.21.1



  parent reply	other threads:[~2020-04-22 13:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 13:31 [PATCH v3 0/9] misc: Trivial static code analyzer fixes Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 1/9] block: Avoid dead assignment Philippe Mathieu-Daudé
2020-04-23 18:11   ` Max Reitz
2020-04-22 13:31 ` [PATCH v3 2/9] blockdev: Remove " Philippe Mathieu-Daudé
2020-04-23 18:11   ` Max Reitz
2020-04-22 13:31 ` [PATCH v3 3/9] hw/i2c/pm_smbus: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 4/9] hw/input/adb-kbd: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` Philippe Mathieu-Daudé [this message]
2020-04-22 13:31 ` [PATCH v3 6/9] hw/isa/i82378: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 7/9] hw/gpio/aspeed_gpio: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 8/9] hw/timer/stm32f2xx_timer: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 9/9] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning Philippe Mathieu-Daudé
2020-05-04  8:55 ` [PATCH v3 0/9] misc: Trivial static code analyzer fixes Philippe Mathieu-Daudé
2020-05-04 10:04 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200422133152.16770-6-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).