From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-trivial@nongnu.org, "Andrew Jeffery" <andrew@aj.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"Joel Stanley" <joel@jms.id.au>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH v3 7/9] hw/gpio/aspeed_gpio: Remove dead assignment
Date: Wed, 22 Apr 2020 15:31:50 +0200 [thread overview]
Message-ID: <20200422133152.16770-8-philmd@redhat.com> (raw)
In-Reply-To: <20200422133152.16770-1-philmd@redhat.com>
Fix warning reported by Clang static code analyzer:
hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its initialization is never read
int set_idx, g_idx = *group_idx;
^~~~~ ~~~~~~~~~~
Reported-by: Clang Static Analyzer
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/gpio/aspeed_gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c
index 41e11ea9b0..bd19db31f4 100644
--- a/hw/gpio/aspeed_gpio.c
+++ b/hw/gpio/aspeed_gpio.c
@@ -714,7 +714,7 @@ static void aspeed_gpio_write(void *opaque, hwaddr offset, uint64_t data,
static int get_set_idx(AspeedGPIOState *s, const char *group, int *group_idx)
{
AspeedGPIOClass *agc = ASPEED_GPIO_GET_CLASS(s);
- int set_idx, g_idx = *group_idx;
+ int set_idx, g_idx;
for (set_idx = 0; set_idx < agc->nr_gpio_sets; set_idx++) {
const GPIOSetProperties *set_props = &agc->props[set_idx];
--
2.21.1
next prev parent reply other threads:[~2020-04-22 13:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 13:31 [PATCH v3 0/9] misc: Trivial static code analyzer fixes Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 1/9] block: Avoid dead assignment Philippe Mathieu-Daudé
2020-04-23 18:11 ` Max Reitz
2020-04-22 13:31 ` [PATCH v3 2/9] blockdev: Remove " Philippe Mathieu-Daudé
2020-04-23 18:11 ` Max Reitz
2020-04-22 13:31 ` [PATCH v3 3/9] hw/i2c/pm_smbus: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 4/9] hw/input/adb-kbd: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 5/9] hw/ide/sii3112: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 6/9] hw/isa/i82378: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` Philippe Mathieu-Daudé [this message]
2020-04-22 13:31 ` [PATCH v3 8/9] hw/timer/stm32f2xx_timer: " Philippe Mathieu-Daudé
2020-04-22 13:31 ` [PATCH v3 9/9] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning Philippe Mathieu-Daudé
2020-05-04 8:55 ` [PATCH v3 0/9] misc: Trivial static code analyzer fixes Philippe Mathieu-Daudé
2020-05-04 10:04 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422133152.16770-8-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).