qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: philmd@redhat.com, David Gibson <david@gibson.dropbear.id.au>,
	qemu-ppc@nongnu.org
Subject: [PATCH v2 3/4] bamboo, sam460ex: Tidy up error message for unsupported RAM size
Date: Wed, 22 Apr 2020 15:48:14 +0200	[thread overview]
Message-ID: <20200422134815.1584-4-armbru@redhat.com> (raw)
In-Reply-To: <20200422134815.1584-1-armbru@redhat.com>

Improve

    $ ppc-softmmu/qemu-system-ppc -M sam460ex -m 4096
    qemu-system-ppc: Max 1 banks of 2048 ,1024 ,512 ,256 ,128 ,64 ,32 MB DIMM/bank supported
    qemu-system-ppc: Possible valid RAM size: 2048

to

    qemu-system-ppc: at most 1 bank of 2048, 1024, 512, 256, 128, 64, 32 MiB each supported
    Possible valid RAM size: 1024 MiB

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/ppc/ppc4xx_devs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/ppc/ppc4xx_devs.c b/hw/ppc/ppc4xx_devs.c
index 3376c43ff5..f1651e04d9 100644
--- a/hw/ppc/ppc4xx_devs.c
+++ b/hw/ppc/ppc4xx_devs.c
@@ -716,11 +716,11 @@ void ppc4xx_sdram_banks(MemoryRegion *ram, int nr_banks,
         for (i = 0; sdram_bank_sizes[i]; i++) {
             g_string_append_printf(s, "%" PRIi64 "%s",
                                    sdram_bank_sizes[i] / MiB,
-                                   sdram_bank_sizes[i + 1] ? " ," : "");
+                                   sdram_bank_sizes[i + 1] ? ", " : "");
         }
-        error_report("Max %d banks of %s MB DIMM/bank supported",
-            nr_banks, s->str);
-        error_report("Possible valid RAM size: %" PRIi64,
+        error_report("at most %d bank%s of %s MiB each supported",
+                     nr_banks, nr_banks == 1 ? "" : "s", s->str);
+        error_printf("Possible valid RAM size: %" PRIi64 " MiB \n",
             used_size ? used_size / MiB : sdram_bank_sizes[i - 1] / MiB);
 
         g_string_free(s, true);
-- 
2.21.1



  parent reply	other threads:[~2020-04-22 13:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 13:48 [PATCH v2 0/4] smbus: SPD fixes Markus Armbruster
2020-04-22 13:48 ` [PATCH v2 1/4] sam460ex: Suppress useless warning on -m 32 and -m 64 Markus Armbruster
2020-04-22 14:44   ` Philippe Mathieu-Daudé
2020-04-22 13:48 ` [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation Markus Armbruster
2020-04-22 14:27   ` BALATON Zoltan
2020-04-22 14:50     ` Philippe Mathieu-Daudé
2020-04-22 19:32       ` BALATON Zoltan
2020-06-26 11:30         ` BALATON Zoltan
2020-06-27  7:17           ` Markus Armbruster
2020-06-27 11:30             ` BALATON Zoltan
2020-06-29 15:56               ` Markus Armbruster
2020-06-30  1:30                 ` BALATON Zoltan
2020-06-29 19:00             ` Philippe Mathieu-Daudé
2020-06-29 21:31               ` BALATON Zoltan
2020-06-30  6:09                 ` Philippe Mathieu-Daudé
2020-06-30  9:27                   ` BALATON Zoltan
2020-04-22 13:48 ` Markus Armbruster [this message]
2020-04-22 14:20   ` [PATCH v2 3/4] bamboo, sam460ex: Tidy up error message for unsupported RAM size BALATON Zoltan
2020-04-22 14:22   ` Philippe Mathieu-Daudé
2020-04-22 13:48 ` [PATCH v2 4/4] smbus: Fix spd_data_generate() for number of banks > 2 Markus Armbruster
2020-04-22 18:26 ` [PATCH v2 0/4] smbus: SPD fixes no-reply
2020-04-29  7:14 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200422134815.1584-4-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).