From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: [PATCH v2 13/15] qom: Simplify object_property_get_enum()
Date: Fri, 24 Apr 2020 10:43:36 +0200 [thread overview]
Message-ID: <20200424084338.26803-14-armbru@redhat.com> (raw)
In-Reply-To: <20200424084338.26803-1-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
qom/object.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 1812f79224..be700e831f 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1550,11 +1550,9 @@ int object_property_get_enum(Object *obj, const char *name,
}
visit_complete(v, &str);
visit_free(v);
- v = string_input_visitor_new(str);
- visit_type_enum(v, name, &ret, enumprop->lookup, errp);
+ ret = qapi_enum_parse(enumprop->lookup, str, -1, errp);
g_free(str);
- visit_free(v);
return ret;
}
--
2.21.1
next prev parent reply other threads:[~2020-04-24 8:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 8:43 [PATCH v2 00/15] qapi: Spring cleaning Markus Armbruster
2020-04-24 8:43 ` [PATCH v2 01/15] qapi: Belatedly update visitor.h's big comment for QAPI modules Markus Armbruster
2020-04-24 8:43 ` [PATCH v2 02/15] qapi: Fix the virtual walk example in visitor.h's big comment Markus Armbruster
2020-04-24 8:43 ` [PATCH v2 03/15] qapi: Fix typo in visit_start_list()'s contract Markus Armbruster
2020-04-24 8:43 ` [PATCH v2 04/15] qapi: Document @errp usage more thoroughly in visitor.h Markus Armbruster
2020-04-24 8:43 ` [PATCH v2 05/15] qapi: Polish prose " Markus Armbruster
2020-04-24 8:43 ` [PATCH v2 06/15] qapi: Assert incomplete object occurs only in dealloc visitor Markus Armbruster
2020-04-24 13:56 ` Eric Blake
2020-04-27 8:51 ` Markus Armbruster
2020-04-24 8:43 ` [PATCH v2 07/15] qapi: Fix Visitor contract for start_alternate() Markus Armbruster
2020-04-24 8:43 ` [PATCH v2 08/15] qapi: Assert output visitors see only valid enum values Markus Armbruster
2020-04-24 8:43 ` [PATCH v2 09/15] qapi: Assert non-input visitors see only valid narrow integers Markus Armbruster
2020-04-24 8:43 ` [PATCH v2 10/15] qapi: Clean up visitor's recovery from input with invalid type Markus Armbruster
2020-04-24 13:57 ` Eric Blake
2020-04-24 8:43 ` [PATCH v2 11/15] qapi: Assert non-input visitors see only valid alternate tags Markus Armbruster
2020-04-24 8:43 ` [PATCH v2 12/15] qapi: Only input visitors can actually fail Markus Armbruster
2020-04-24 8:43 ` Markus Armbruster [this message]
2020-04-24 8:43 ` [PATCH v2 14/15] qapi: Disallow qmp_marshal_FOO(NULL, ...) Markus Armbruster
2020-04-24 14:01 ` Eric Blake
2020-04-24 8:43 ` [PATCH v2 15/15] qapi: Generate simpler marshalling code when no arguments Markus Armbruster
2020-04-24 14:02 ` Eric Blake
2020-04-24 10:06 ` [PATCH v2 00/15] qapi: Spring cleaning no-reply
2020-04-24 14:06 ` Eric Blake
2020-04-29 7:46 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424084338.26803-14-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).