qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: [PATCH v2 01/15] qapi: Belatedly update visitor.h's big comment for QAPI modules
Date: Fri, 24 Apr 2020 10:43:24 +0200	[thread overview]
Message-ID: <20200424084338.26803-2-armbru@redhat.com> (raw)
In-Reply-To: <20200424084338.26803-1-armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 include/qapi/visitor.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h
index c5b23851a1..f8a0fc1ea9 100644
--- a/include/qapi/visitor.h
+++ b/include/qapi/visitor.h
@@ -58,7 +58,7 @@
  *
  * where T is FOO for scalar types, and FOO * otherwise.  The scalar
  * visitors are declared here; the remaining visitors are generated in
- * qapi-visit.h.
+ * qapi-visit-MODULE.h.
  *
  * The @name parameter of visit_type_FOO() describes the relation
  * between this QAPI value and its parent container.  When visiting
@@ -86,16 +86,16 @@
  * by manual construction.
  *
  * For the QAPI object types (structs, unions, and alternates), there
- * is an additional generated function in qapi-visit.h compatible
- * with:
+ * is an additional generated function in qapi-visit-MODULE.h
+ * compatible with:
  *
  * void visit_type_FOO_members(Visitor *v, FOO *obj, Error **errp);
  *
  * for visiting the members of a type without also allocating the QAPI
  * struct.
  *
- * Additionally, in qapi-types.h, all QAPI pointer types (structs,
- * unions, alternates, and lists) have a generated function compatible
+ * Additionally, QAPI pointer types (structs, unions, alternates, and
+ * lists) have a generated function in qapi-types-MODULE.h compatible
  * with:
  *
  * void qapi_free_FOO(FOO *obj);
-- 
2.21.1



  reply	other threads:[~2020-04-24  8:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24  8:43 [PATCH v2 00/15] qapi: Spring cleaning Markus Armbruster
2020-04-24  8:43 ` Markus Armbruster [this message]
2020-04-24  8:43 ` [PATCH v2 02/15] qapi: Fix the virtual walk example in visitor.h's big comment Markus Armbruster
2020-04-24  8:43 ` [PATCH v2 03/15] qapi: Fix typo in visit_start_list()'s contract Markus Armbruster
2020-04-24  8:43 ` [PATCH v2 04/15] qapi: Document @errp usage more thoroughly in visitor.h Markus Armbruster
2020-04-24  8:43 ` [PATCH v2 05/15] qapi: Polish prose " Markus Armbruster
2020-04-24  8:43 ` [PATCH v2 06/15] qapi: Assert incomplete object occurs only in dealloc visitor Markus Armbruster
2020-04-24 13:56   ` Eric Blake
2020-04-27  8:51     ` Markus Armbruster
2020-04-24  8:43 ` [PATCH v2 07/15] qapi: Fix Visitor contract for start_alternate() Markus Armbruster
2020-04-24  8:43 ` [PATCH v2 08/15] qapi: Assert output visitors see only valid enum values Markus Armbruster
2020-04-24  8:43 ` [PATCH v2 09/15] qapi: Assert non-input visitors see only valid narrow integers Markus Armbruster
2020-04-24  8:43 ` [PATCH v2 10/15] qapi: Clean up visitor's recovery from input with invalid type Markus Armbruster
2020-04-24 13:57   ` Eric Blake
2020-04-24  8:43 ` [PATCH v2 11/15] qapi: Assert non-input visitors see only valid alternate tags Markus Armbruster
2020-04-24  8:43 ` [PATCH v2 12/15] qapi: Only input visitors can actually fail Markus Armbruster
2020-04-24  8:43 ` [PATCH v2 13/15] qom: Simplify object_property_get_enum() Markus Armbruster
2020-04-24  8:43 ` [PATCH v2 14/15] qapi: Disallow qmp_marshal_FOO(NULL, ...) Markus Armbruster
2020-04-24 14:01   ` Eric Blake
2020-04-24  8:43 ` [PATCH v2 15/15] qapi: Generate simpler marshalling code when no arguments Markus Armbruster
2020-04-24 14:02   ` Eric Blake
2020-04-24 10:06 ` [PATCH v2 00/15] qapi: Spring cleaning no-reply
2020-04-24 14:06   ` Eric Blake
2020-04-29  7:46 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200424084338.26803-2-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).