qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: elena.ufimtseva@oracle.com, fam@euphon.net,
	swapnil.ingle@nutanix.com, john.g.johnson@oracle.com,
	qemu-devel@nongnu.org, kraxel@redhat.com, jag.raman@oracle.com,
	quintela@redhat.com, mst@redhat.com, armbru@redhat.com,
	kanth.ghatraju@oracle.com, felipe@nutanix.com, thuth@redhat.com,
	ehabkost@redhat.com, konrad.wilk@oracle.com, dgilbert@redhat.com,
	liran.alon@oracle.com, pbonzini@redhat.com, rth@twiddle.net,
	kwolf@redhat.com, mreitz@redhat.com, ross.lagerwall@citrix.com,
	marcandre.lureau@gmail.com, thanos.makatos@nutanix.com
Subject: Re: [PATCH RESEND v6 00/36] Initial support for multi-process qemu
Date: Fri, 24 Apr 2020 13:53:22 +0100	[thread overview]
Message-ID: <20200424125322.GI1212635@redhat.com> (raw)
In-Reply-To: <20200424124823.GC189569@stefanha-x1.localdomain>

On Fri, Apr 24, 2020 at 01:48:23PM +0100, Stefan Hajnoczi wrote:
> On Wed, Apr 22, 2020 at 09:13:35PM -0700, elena.ufimtseva@oracle.com wrote:
> > There is an error in travis-ci build test which does not get reproduced.
> > 
> >  TEST    iotest-qcow2: 041 [fail]
> > QEMU          -- "/home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nodefaults -display none -accel qtest
> > QEMU_IMG      -- "/home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/../../qemu-img" 
> > QEMU_IO       -- "/home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/../../qemu-io"  --cache writeback --aio threads -f qcow2
> > QEMU_NBD      -- "/home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/../../qemu-nbd" 
> > IMGFMT        -- qcow2 (compat=1.1)
> > IMGPROTO      -- file
> > PLATFORM      -- Linux/x86_64 travis-job-fc4e2553-b470-4a8b-812e-a4fcf8ba094f 5.0.0-1031-gcp
> > TEST_DIR      -- /home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/scratch
> > SOCK_DIR      -- /tmp/tmp.LOmYANt5Od
> > SOCKET_SCM_HELPER -- /home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/socket_scm_helper
> > --- /home/travis/build/elena-ufimtseva/qemu-multiprocess/tests/qemu-iotests/041.out	2020-04-22 00:17:23.701844698 +0000
> > +++ /home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/041.out.bad	2020-04-22 00:24:39.234343858 +0000
> > @@ -1,5 +1,29 @@
> > -..............................................................................................
> > +........................FF....................................................................
> > +======================================================================
> > +FAIL: test_with_other_parent (__main__.TestRepairQuorum)
> > +----------------------------------------------------------------------
> > +Traceback (most recent call last):
> > +  File "041", line 1049, in test_with_other_parent
> > +    self.assert_qmp(result, 'return', {})
> > +  File "/home/travis/build/elena-ufimtseva/qemu-multiprocess/tests/qemu-iotests/iotests.py", line 821, in assert_qmp
> > +    result = self.dictpath(d, path)
> > +  File "/home/travis/build/elena-ufimtseva/qemu-multiprocess/tests/qemu-iotests/iotests.py", line 797, in dictpath
> > +    self.fail('failed path traversal for "%s" in "%s"' % (path, str(d)))
> > +AssertionError: failed path traversal for "return" in "{'error': {'class': 'GenericError', 'desc': "UNIX socket path '/home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/scratch/nbd.sock' is too long"}}"
> 
> UNIX Domain Socket paths have to be 108 characters or less.  The path in
> the failed test case is 110 characters long.  You could rename your
> branch to "mpqemu" to solve this failure.

Renaming is a pretty poor band-aid.

We should fix the i/o tests instead, so that they use a scratch dir under
$TMP to store unix sockets needed by tests instead.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2020-04-24 12:54 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23  4:13 [PATCH RESEND v6 00/36] Initial support for multi-process qemu elena.ufimtseva
2020-04-23  4:13 ` [PATCH RESEND v6 01/36] memory: alloc RAM from file at offset elena.ufimtseva
2020-05-12  8:26   ` Stefan Hajnoczi
2020-05-12  8:48   ` Daniel P. Berrangé
2020-05-12 11:56     ` Jag Raman
2020-05-13  8:40       ` Stefan Hajnoczi
2020-05-13 15:25         ` Igor Mammedov
2020-05-13 20:08           ` Jag Raman
2020-05-14  9:47             ` Igor Mammedov
2020-05-14  9:51             ` Dr. David Alan Gilbert
2020-04-23  4:13 ` [PATCH RESEND v6 02/36] multi-process: Refactor machine_init and exit notifiers elena.ufimtseva
2020-04-23 14:13   ` Philippe Mathieu-Daudé
2020-04-23  4:13 ` [PATCH RESEND v6 03/36] command-line: refractor parser code elena.ufimtseva
2020-04-24 12:55   ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 04/36] multi-process: Refactor chardev functions out of vl.c elena.ufimtseva
2020-04-23  4:13 ` [PATCH RESEND v6 05/36] multi-process: Refactor monitor " elena.ufimtseva
2020-04-24 13:02   ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 06/36] monitor: destaticize HMP commands elena.ufimtseva
2020-04-23 14:14   ` Philippe Mathieu-Daudé
2020-04-23 15:07     ` Jag Raman
2020-04-23 15:58       ` Philippe Mathieu-Daudé
2020-04-23  4:13 ` [PATCH RESEND v6 07/36] multi-process: add a command line option for debug file elena.ufimtseva
2020-04-23  4:13 ` [PATCH RESEND v6 08/36] multi-process: Add stub functions to facilitate build of multi-process elena.ufimtseva
2020-04-24 13:12   ` Stefan Hajnoczi
2020-04-24 13:47     ` Jag Raman
2020-04-28 16:29       ` Stefan Hajnoczi
2020-04-28 18:58         ` Jag Raman
2020-04-29  9:41           ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 09/36] multi-process: Add config option for multi-process QEMU elena.ufimtseva
2020-04-24 13:47   ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 10/36] multi-process: build system for remote device process elena.ufimtseva
2020-04-24 15:04   ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 11/36] multi-process: define mpqemu-link object elena.ufimtseva
2020-05-12  8:56   ` Stefan Hajnoczi
2020-05-12 12:09     ` Jag Raman
2020-04-23  4:13 ` [PATCH RESEND v6 12/36] multi-process: add functions to synchronize proxy and remote endpoints elena.ufimtseva
2020-05-12 10:21   ` Stefan Hajnoczi
2020-05-12 12:28     ` Jag Raman
2020-05-13  8:43       ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 13/36] multi-process: setup PCI host bridge for remote device elena.ufimtseva
2020-05-12 10:31   ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 14/36] multi-process: setup a machine object for remote device process elena.ufimtseva
2020-05-12 10:43   ` Stefan Hajnoczi
2020-05-12 12:12     ` Jag Raman
2020-04-23  4:13 ` [PATCH RESEND v6 15/36] multi-process: setup memory manager for remote device elena.ufimtseva
2020-05-12 12:11   ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 16/36] multi-process: remote process initialization elena.ufimtseva
2020-04-23  4:13 ` [PATCH RESEND v6 17/36] multi-process: introduce proxy object elena.ufimtseva
2020-05-12 12:23   ` Stefan Hajnoczi
2020-05-12 12:35     ` Jag Raman
2020-04-23  4:13 ` [PATCH RESEND v6 18/36] multi-process: Initialize Proxy Object's communication channel elena.ufimtseva
2020-05-12 12:35   ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 19/36] multi-process: Connect Proxy Object with device in the remote process elena.ufimtseva
2020-05-12 12:54   ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 20/36] multi-process: Forward PCI config space acceses to " elena.ufimtseva
2020-05-12 13:50   ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 21/36] multi-process: PCI BAR read/write handling for proxy & remote endpoints elena.ufimtseva
2020-05-12 14:19   ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 22/36] multi-process: Synchronize remote memory elena.ufimtseva
2020-05-12 15:07   ` Stefan Hajnoczi
2020-05-12 15:49     ` Dr. David Alan Gilbert
2020-04-23  4:13 ` [PATCH RESEND v6 23/36] multi-process: create IOHUB object to handle irq elena.ufimtseva
2020-05-12 15:57   ` Stefan Hajnoczi
2020-05-12 16:12   ` Stefan Hajnoczi
2020-04-23  4:13 ` [PATCH RESEND v6 24/36] multi-process: Retrieve PCI info from remote process elena.ufimtseva
2020-05-12 16:07   ` Stefan Hajnoczi
2020-04-23  4:14 ` [PATCH RESEND v6 25/36] multi-process: Introduce build flags to separate remote process code elena.ufimtseva
2020-04-23  4:14 ` [PATCH RESEND v6 26/36] multi-process: add parse_cmdline in remote process elena.ufimtseva
2020-04-23  4:14 ` [PATCH RESEND v6 27/36] multi-process: add support to parse device option elena.ufimtseva
2020-04-23  4:14 ` [PATCH RESEND v6 28/36] multi-process: send heartbeat messages to remote elena.ufimtseva
2020-04-23  4:14 ` [PATCH RESEND v6 29/36] multi-process: handle heartbeat messages in remote process elena.ufimtseva
2020-04-23  4:14 ` [PATCH RESEND v6 30/36] multi-process: perform device reset in the " elena.ufimtseva
2020-04-23  4:14 ` [PATCH RESEND v6 31/36] multi-process/mon: choose HMP commands based on target elena.ufimtseva
2020-04-23  4:14 ` [PATCH RESEND v6 32/36] multi-process/mon: stub functions to enable QMP module for remote process elena.ufimtseva
2020-04-23  4:14 ` [PATCH RESEND v6 33/36] multi-process/mon: enable QMP module support in the " elena.ufimtseva
2020-04-23  4:14 ` [PATCH RESEND v6 34/36] multi-process/mon: Initialize QMP module for remote processes elena.ufimtseva
2020-04-23  4:14 ` [PATCH RESEND v6 35/36] multi-process: add the concept description to docs/devel/qemu-multiprocess elena.ufimtseva
2020-04-23  4:14 ` [PATCH RESEND v6 36/36] multi-process: add configure and usage information elena.ufimtseva
2020-04-23 13:54   ` 罗勇刚(Yonggang Luo)
2020-04-23 15:01     ` Jag Raman
2020-04-23 22:56       ` 罗勇刚(Yonggang Luo)
2020-04-24  0:34       ` 罗勇刚(Yonggang Luo)
2020-04-24 12:48 ` [PATCH RESEND v6 00/36] Initial support for multi-process qemu Stefan Hajnoczi
2020-04-24 12:53   ` Daniel P. Berrangé [this message]
2020-04-24 12:53   ` Eric Blake
2020-04-24 13:42     ` Max Reitz
2020-04-28 17:29 ` Stefan Hajnoczi
2020-04-28 17:47   ` Michael S. Tsirkin
2020-04-29  9:30     ` Stefan Hajnoczi
2020-04-29  9:59       ` Michael S. Tsirkin
2020-05-11 14:40 ` Stefan Hajnoczi
2020-05-11 19:30   ` Jag Raman
2020-05-12 16:13     ` Stefan Hajnoczi
2020-05-12 16:55       ` Jag Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200424125322.GI1212635@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=elena.ufimtseva@oracle.com \
    --cc=fam@euphon.net \
    --cc=felipe@nutanix.com \
    --cc=jag.raman@oracle.com \
    --cc=john.g.johnson@oracle.com \
    --cc=kanth.ghatraju@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=liran.alon@oracle.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    --cc=swapnil.ingle@nutanix.com \
    --cc=thanos.makatos@nutanix.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).