* [PATCH] iotests/041: Fix NBD socket path
@ 2020-04-24 13:46 Max Reitz
2020-04-24 14:27 ` Eric Blake
2020-05-04 13:24 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Max Reitz @ 2020-04-24 13:46 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, qemu-devel, Max Reitz
We should put all UNIX socket files into the sock_dir, not test_dir.
Reported-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/041 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index 5d67bf14bf..46bf1f6c81 100755
--- a/tests/qemu-iotests/041
+++ b/tests/qemu-iotests/041
@@ -35,7 +35,7 @@ quorum_img3 = os.path.join(iotests.test_dir, 'quorum3.img')
quorum_repair_img = os.path.join(iotests.test_dir, 'quorum_repair.img')
quorum_snapshot_file = os.path.join(iotests.test_dir, 'quorum_snapshot.img')
-nbd_sock_path = os.path.join(iotests.test_dir, 'nbd.sock')
+nbd_sock_path = os.path.join(iotests.sock_dir, 'nbd.sock')
class TestSingleDrive(iotests.QMPTestCase):
image_len = 1 * 1024 * 1024 # MB
--
2.25.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iotests/041: Fix NBD socket path
2020-04-24 13:46 [PATCH] iotests/041: Fix NBD socket path Max Reitz
@ 2020-04-24 14:27 ` Eric Blake
2020-05-04 13:24 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2020-04-24 14:27 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, qemu-devel
On 4/24/20 8:46 AM, Max Reitz wrote:
> We should put all UNIX socket files into the sock_dir, not test_dir.
>
> Reported-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/041 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
I'm happy to queue this through my NBD tree, if you don't beat me to it
through an iotest pull request.
> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
> index 5d67bf14bf..46bf1f6c81 100755
> --- a/tests/qemu-iotests/041
> +++ b/tests/qemu-iotests/041
> @@ -35,7 +35,7 @@ quorum_img3 = os.path.join(iotests.test_dir, 'quorum3.img')
> quorum_repair_img = os.path.join(iotests.test_dir, 'quorum_repair.img')
> quorum_snapshot_file = os.path.join(iotests.test_dir, 'quorum_snapshot.img')
>
> -nbd_sock_path = os.path.join(iotests.test_dir, 'nbd.sock')
> +nbd_sock_path = os.path.join(iotests.sock_dir, 'nbd.sock')
>
> class TestSingleDrive(iotests.QMPTestCase):
> image_len = 1 * 1024 * 1024 # MB
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iotests/041: Fix NBD socket path
2020-04-24 13:46 [PATCH] iotests/041: Fix NBD socket path Max Reitz
2020-04-24 14:27 ` Eric Blake
@ 2020-05-04 13:24 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2020-05-04 13:24 UTC (permalink / raw)
To: Max Reitz; +Cc: Kevin Wolf, qemu-devel, qemu-block
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
On Fri, Apr 24, 2020 at 03:46:26PM +0200, Max Reitz wrote:
> We should put all UNIX socket files into the sock_dir, not test_dir.
>
> Reported-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/041 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Cool, thanks for fixing this!
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-04 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-24 13:46 [PATCH] iotests/041: Fix NBD socket path Max Reitz
2020-04-24 14:27 ` Eric Blake
2020-05-04 13:24 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).