From: Helge Deller <deller@gmx.de>
To: Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org
Subject: [PATCH] linux-user: Drop unnecessary check in signalfd4 syscall
Date: Fri, 24 Apr 2020 23:04:22 +0200 [thread overview]
Message-ID: <20200424210422.GB26282@ls3530.fritz.box> (raw)
The signalfd4() syscall takes optional O_NONBLOCK and O_CLOEXEC fcntl
flags. If the user gave any other invalid flags, the host syscall will
return correct error codes, so simply drop the extra check here.
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 05f03919ff..ebf0d38321 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -7176,9 +7176,6 @@ static abi_long do_signalfd4(int fd, abi_long mask, int flags)
sigset_t host_mask;
abi_long ret;
- if (flags & ~(TARGET_O_NONBLOCK | TARGET_O_CLOEXEC)) {
- return -TARGET_EINVAL;
- }
if (!lock_user_struct(VERIFY_READ, target_mask, mask, 1)) {
return -TARGET_EFAULT;
}
next reply other threads:[~2020-04-24 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 21:04 Helge Deller [this message]
2020-04-25 8:39 ` [PATCH] linux-user: Drop unnecessary check in signalfd4 syscall Laurent Vivier
2020-04-25 9:24 ` Helge Deller
2020-04-25 10:03 ` Laurent Vivier
2020-04-25 21:48 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424210422.GB26282@ls3530.fritz.box \
--to=deller@gmx.de \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).