qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, integration@gluster.org,
	berto@igalia.com, pavel.dovgaluk@ispras.ru, dillaman@redhat.com,
	qemu-devel@nongnu.org, pl@kamp.de, ronniesahlberg@gmail.com,
	mreitz@redhat.com, den@openvz.org, sheepdog@lists.wpkg.org,
	vsementsov@virtuozzo.com, stefanha@redhat.com,
	namei.unix@gmail.com, pbonzini@redhat.com, sw@weilnetz.de,
	jsnow@redhat.com, ari@tuxera.com
Subject: [PATCH v2 01/17] block/throttle-groups: throttle_group_co_io_limits_intercept(): 64bit bytes
Date: Mon, 27 Apr 2020 11:23:09 +0300	[thread overview]
Message-ID: <20200427082325.10414-2-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20200427082325.10414-1-vsementsov@virtuozzo.com>

The function is called from 64bit io handlers, and bytes is just passed
to throttle_account() which is 64bit too (unsigned though). So, let's
convert intermediate argument to 64bit too.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 include/block/throttle-groups.h | 2 +-
 block/throttle-groups.c         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/block/throttle-groups.h b/include/block/throttle-groups.h
index 712a8e64b4..f921994b8a 100644
--- a/include/block/throttle-groups.h
+++ b/include/block/throttle-groups.h
@@ -76,7 +76,7 @@ void throttle_group_unregister_tgm(ThrottleGroupMember *tgm);
 void throttle_group_restart_tgm(ThrottleGroupMember *tgm);
 
 void coroutine_fn throttle_group_co_io_limits_intercept(ThrottleGroupMember *tgm,
-                                                        unsigned int bytes,
+                                                        int64_t bytes,
                                                         bool is_write);
 void throttle_group_attach_aio_context(ThrottleGroupMember *tgm,
                                        AioContext *new_context);
diff --git a/block/throttle-groups.c b/block/throttle-groups.c
index 37695b0cd7..37d1b7a8b8 100644
--- a/block/throttle-groups.c
+++ b/block/throttle-groups.c
@@ -358,7 +358,7 @@ static void schedule_next_request(ThrottleGroupMember *tgm, bool is_write)
  * @is_write:  the type of operation (read/write)
  */
 void coroutine_fn throttle_group_co_io_limits_intercept(ThrottleGroupMember *tgm,
-                                                        unsigned int bytes,
+                                                        int64_t bytes,
                                                         bool is_write)
 {
     bool must_wait;
-- 
2.21.0



  reply	other threads:[~2020-04-27  8:25 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27  8:23 [PATCH v2 00/17] 64bit block-layer Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` Vladimir Sementsov-Ogievskiy [this message]
2020-04-27 10:05   ` [PATCH v2 01/17] block/throttle-groups: throttle_group_co_io_limits_intercept(): 64bit bytes Philippe Mathieu-Daudé
2020-04-27 14:12     ` Eric Blake
2020-04-28 22:09   ` Eric Blake
2020-04-29  5:05     ` Vladimir Sementsov-Ogievskiy
2020-04-29 12:53       ` Eric Blake
2020-04-27  8:23 ` [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests Vladimir Sementsov-Ogievskiy
2020-04-27 10:11   ` Philippe Mathieu-Daudé
2020-04-27 11:26     ` Vladimir Sementsov-Ogievskiy
2020-04-27 11:40       ` Philippe Mathieu-Daudé
2020-04-27 11:26   ` Vladimir Sementsov-Ogievskiy
2020-04-29 15:50   ` Eric Blake
2020-04-30  8:21     ` Vladimir Sementsov-Ogievskiy
2020-04-30  8:33     ` Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 03/17] block/io: use int64_t bytes parameter in bdrv_check_byte_request() Vladimir Sementsov-Ogievskiy
2020-04-29 19:27   ` Eric Blake
2020-04-30  5:15     ` Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 04/17] block/io: use int64_t bytes in driver wrappers Vladimir Sementsov-Ogievskiy
2020-04-29 20:27   ` Eric Blake
2020-04-27  8:23 ` [PATCH v2 05/17] block/io: support int64_t bytes in bdrv_co_do_pwrite_zeroes() Vladimir Sementsov-Ogievskiy
2020-04-29 21:14   ` Eric Blake
2020-04-27  8:23 ` [PATCH v2 06/17] block/io: support int64_t bytes in bdrv_aligned_pwritev() Vladimir Sementsov-Ogievskiy
2020-04-29 22:04   ` Eric Blake
2020-04-30  5:25     ` Vladimir Sementsov-Ogievskiy
2020-04-30  5:30       ` Vladimir Sementsov-Ogievskiy
2020-04-30  5:37         ` Vladimir Sementsov-Ogievskiy
2020-04-30  9:26     ` Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 07/17] block/io: support int64_t bytes in bdrv_co_do_copy_on_readv() Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 08/17] block/io: support int64_t bytes in bdrv_aligned_preadv() Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 09/17] block/io: support int64_t bytes in bdrv_co_p{read, write}v_part() Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 10/17] block/io: support int64_t bytes in read/write wrappers Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 11/17] block/io: use int64_t bytes in copy_range Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 12/17] block/block-backend: convert blk io path to use int64_t parameters Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 13/17] block: use int64_t instead of uint64_t in driver read handlers Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 14/17] block: use int64_t instead of uint64_t in driver write handlers Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 15/17] block: use int64_t instead of uint64_t in copy_range driver handlers Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 16/17] block: use int64_t instead of int in driver write_zeroes handlers Vladimir Sementsov-Ogievskiy
2020-04-27  8:23 ` [PATCH v2 17/17] block: use int64_t instead of int in driver discard handlers Vladimir Sementsov-Ogievskiy
2020-04-27  9:30 ` [PATCH v2 00/17] 64bit block-layer no-reply
2020-04-27 10:02 ` no-reply
2020-04-27 10:08 ` no-reply
2020-04-27 14:17 ` Vladimir Sementsov-Ogievskiy
2020-04-28 21:33 ` Eric Blake
2020-04-29  5:24   ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200427082325.10414-2-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=ari@tuxera.com \
    --cc=berto@igalia.com \
    --cc=den@openvz.org \
    --cc=dillaman@redhat.com \
    --cc=fam@euphon.net \
    --cc=integration@gluster.org \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=namei.unix@gmail.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=sheepdog@lists.wpkg.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).