From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B82C4CECC for ; Mon, 27 Apr 2020 18:01:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECDA120656 for ; Mon, 27 Apr 2020 18:01:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z8RZMzQD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECDA120656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT83y-0000u0-1C for qemu-devel@archiver.kernel.org; Mon, 27 Apr 2020 14:01:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60506) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT82S-000830-O1 for qemu-devel@nongnu.org; Mon, 27 Apr 2020 13:59:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jT82R-0006dy-P0 for qemu-devel@nongnu.org; Mon, 27 Apr 2020 13:59:28 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:31244 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jT82R-0006Zl-AN for qemu-devel@nongnu.org; Mon, 27 Apr 2020 13:59:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588010366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pdr3ZhGtf/0Oemse+4TtYDHnyL+/Xb6gIB9/fMOcUSs=; b=Z8RZMzQDi3JklTZtqUvX7sNNaa1FxDm2WzI7LLYhafVkuiIuI1qrGiYPdBp75DKuSyieLf oazi5Aa1xU5Ng5oLEWmeWJx83FK6D+n8xRfLRASUgHFOSEmWJyu7w2V2KVfp4mUqjN2A0+ 2K2qwhAYEo3eaDg37ziMciLl7x195b4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-411-HEJq9ARsNGa37OZW_7qFIw-1; Mon, 27 Apr 2020 13:59:24 -0400 X-MC-Unique: HEJq9ARsNGa37OZW_7qFIw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 973E318FF682 for ; Mon, 27 Apr 2020 17:59:23 +0000 (UTC) Received: from work-vm (ovpn-112-62.ams2.redhat.com [10.36.112.62]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 18AA366060; Mon, 27 Apr 2020 17:59:04 +0000 (UTC) Date: Mon, 27 Apr 2020 18:59:02 +0100 From: "Dr. David Alan Gilbert" To: Max Reitz Subject: Re: [PATCH] virtiofsd: Show submounts Message-ID: <20200427175902.GM2923@work-vm> References: <20200424133516.73077-1-mreitz@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200424133516.73077-1-mreitz@redhat.com> User-Agent: Mutt/1.13.4 (2020-02-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/26 23:33:12 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Max Reitz (mreitz@redhat.com) wrote: > Currently, setup_mounts() bind-mounts the shared directory without > MS_REC. This makes all submounts disappear. >=20 > Pass MS_REC so that the guest can see submounts again. Thanks! > Fixes: 3ca8a2b1c83eb185c232a4e87abbb65495263756 Should this actually be 5baa3b8e95064c2434bd9e2f312edd5e9ae275dc ? > Signed-off-by: Max Reitz > --- > tools/virtiofsd/passthrough_ll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrou= gh_ll.c > index 4c35c95b25..9d7f863e66 100644 > --- a/tools/virtiofsd/passthrough_ll.c > +++ b/tools/virtiofsd/passthrough_ll.c > @@ -2643,7 +2643,7 @@ static void setup_mounts(const char *source) > int oldroot; > int newroot; > =20 > - if (mount(source, source, NULL, MS_BIND, NULL) < 0) { > + if (mount(source, source, NULL, MS_BIND | MS_REC, NULL) < 0) { > fuse_log(FUSE_LOG_ERR, "mount(%s, %s, MS_BIND): %m\n", source, s= ource); > exit(1); > } Do we want MS_SLAVE to pick up future mounts that might happenf rom the host? What's the interaction between this and the MS_REC|MS_SLAVE that we have a few lines above for / ? Dave > --=20 > 2.25.3 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK