From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: ehabkost@redhat.com, qemu-block@nongnu.org,
John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, armbru@redhat.com, philmd@redhat.com
Subject: Re: [PATCH v10 00/14] iotests: use python logging
Date: Tue, 28 Apr 2020 14:21:07 +0200 [thread overview]
Message-ID: <20200428122107.GD5789@linux.fritz.box> (raw)
In-Reply-To: <a63ac7e2-51fd-7d02-3e7d-be14912bd103@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]
Am 28.04.2020 um 13:46 hat Max Reitz geschrieben:
> On 31.03.20 02:00, John Snow wrote:
> > This series uses python logging to enable output conditionally on
> > iotests.log(). We unify an initialization call (which also enables
> > debugging output for those tests with -d) and then make the switch
> > inside of iotests.
> >
> > It will help alleviate the need to create logged/unlogged versions
> > of all the various helpers we have made.
> >
> > Also, I got lost and accidentally delinted iotests while I was here.
> > Sorry about that. By version 9, it's now the overwhelming focus of
> > this series. No good deed, etc.
>
> Seems like nobody else wants it, so I thank you and let you know that
> I’ve applied this series to my block-next branch:
>
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block-next
John said he wanted to address my comment on patch 14, so I expected him
to send another version. This need not stop this series (we can still
fix that on top), but just as an explanation why I didn't take it yet.
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-28 12:22 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 0:00 [PATCH v10 00/14] iotests: use python logging John Snow
2020-03-31 0:00 ` [PATCH v10 01/14] iotests: do a light delinting John Snow
2020-03-31 0:00 ` [PATCH v10 02/14] iotests: don't use 'format' for drive_add John Snow
2020-03-31 0:00 ` [PATCH v10 03/14] iotests: ignore import warnings from pylint John Snow
2020-03-31 0:00 ` [PATCH v10 04/14] iotests: replace mutable list default args John Snow
2020-03-31 0:00 ` [PATCH v10 05/14] iotests: add pylintrc file John Snow
2020-03-31 0:00 ` [PATCH v10 06/14] iotests: alphabetize standard imports John Snow
2020-03-31 8:00 ` Philippe Mathieu-Daudé
2020-03-31 0:00 ` [PATCH v10 07/14] iotests: drop pre-Python 3.4 compatibility code John Snow
2020-03-31 0:00 ` [PATCH v10 08/14] iotests: touch up log function signature John Snow
2020-03-31 0:00 ` [PATCH v10 09/14] iotests: limit line length to 79 chars John Snow
2020-03-31 0:00 ` [PATCH v10 10/14] iotests: add hmp helper with logging John Snow
2020-03-31 10:21 ` Max Reitz
2020-03-31 14:00 ` Kevin Wolf
2020-04-01 12:28 ` Max Reitz
2020-04-01 12:42 ` Max Reitz
2020-04-01 13:51 ` Kevin Wolf
2020-04-01 14:53 ` Max Reitz
2020-03-31 17:23 ` John Snow
2020-03-31 17:39 ` Kevin Wolf
2020-04-01 12:40 ` Max Reitz
2020-04-02 18:27 ` John Snow
2020-04-03 7:46 ` Kevin Wolf
2020-04-03 8:57 ` Max Reitz
2020-04-04 2:38 ` John Snow
2020-03-31 0:00 ` [PATCH v10 11/14] iotests: add script_initialize John Snow
2020-03-31 0:00 ` [PATCH v10 12/14] iotest 258: use script_main John Snow
2020-03-31 0:00 ` [PATCH v10 13/14] iotests: Mark verify functions as private John Snow
2020-03-31 10:40 ` Max Reitz
2020-03-31 0:00 ` [PATCH v10 14/14] iotests: use python logging for iotests.log() John Snow
2020-03-31 13:44 ` Kevin Wolf
2020-05-14 6:24 ` John Snow
2020-05-14 10:06 ` Kevin Wolf
2020-05-14 19:54 ` John Snow
2020-05-15 9:03 ` Kevin Wolf
2020-05-18 18:29 ` John Snow
2020-03-31 15:07 ` [PATCH v10 00/14] iotests: use python logging Kevin Wolf
2020-04-28 11:46 ` Max Reitz
2020-04-28 12:21 ` Kevin Wolf [this message]
2020-04-28 17:36 ` John Snow
2020-04-29 8:08 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428122107.GD5789@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).