qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, dgilbert@redhat.com, Peter Xu <peterx@redhat.com>
Subject: [PATCH RFC v2 7/9] KVM: Cache kvm slot dirty bitmap size
Date: Tue, 28 Apr 2020 16:05:07 -0400	[thread overview]
Message-ID: <20200428200509.13150-5-peterx@redhat.com> (raw)
In-Reply-To: <20200428195707.11980-1-peterx@redhat.com>

Cache it too because we'll reference it more frequently in the future.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 accel/kvm/kvm-all.c      | 1 +
 include/sysemu/kvm_int.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index dd21b86efa..2d581013cc 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -558,6 +558,7 @@ static void kvm_slot_init_dirty_bitmap(KVMSlot *mem)
     hwaddr bitmap_size = ALIGN(((mem->memory_size) >> TARGET_PAGE_BITS),
                                         /*HOST_LONG_BITS*/ 64) / 8;
     mem->dirty_bmap = g_malloc0(bitmap_size);
+    mem->dirty_bmap_size = bitmap_size;
 }
 
 /* Sync dirty bitmap from kernel to KVMSlot.dirty_bmap */
diff --git a/include/sysemu/kvm_int.h b/include/sysemu/kvm_int.h
index 1a19bfef80..71c9946ecf 100644
--- a/include/sysemu/kvm_int.h
+++ b/include/sysemu/kvm_int.h
@@ -23,6 +23,7 @@ typedef struct KVMSlot
     int old_flags;
     /* Dirty bitmap cache for the slot */
     unsigned long *dirty_bmap;
+    unsigned long dirty_bmap_size;
     /* Cache of the address space ID */
     int as_id;
     /* Cache of the offset in ram address space */
-- 
2.24.1



  parent reply	other threads:[~2020-04-28 20:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 19:56 [PATCH RFC v2 0/9] KVM: Dirty ring support (QEMU part) Peter Xu
2020-04-28 19:56 ` [PATCH RFC v2 1/9] KVM: Fixup kvm_log_clear_one_slot() ioctl return check Peter Xu
2020-04-28 19:57 ` [PATCH RFC v2 2/9] linux-headers: Update Peter Xu
2020-04-28 20:05 ` [PATCH RFC v2 3/9] memory: Introduce log_sync_global() to memory listener Peter Xu
2020-04-28 20:05 ` [PATCH RFC v2 4/9] KVM: Create the KVMSlot dirty bitmap on flag changes Peter Xu
2020-04-28 20:05 ` [PATCH RFC v2 5/9] KVM: Provide helper to get kvm dirty log Peter Xu
2020-04-28 20:05 ` [PATCH RFC v2 6/9] KVM: Provide helper to sync dirty bitmap from slot to ramblock Peter Xu
2020-04-28 20:05 ` Peter Xu [this message]
2020-04-28 20:05 ` [PATCH RFC v2 8/9] KVM: Add dirty-gfn-count property Peter Xu
2020-04-28 20:05 ` [PATCH RFC v2 9/9] KVM: Dirty ring support Peter Xu
2020-04-28 20:20   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200428200509.13150-5-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).