From: Yan Zhao <yan.y.zhao@intel.com>
To: pbonzini@redhat.com, alex.williamson@redhat.com
Cc: Yan Zhao <yan.y.zhao@intel.com>,
xin.zeng@intel.com, philmd@redhat.com, qemu-devel@nongnu.org
Subject: [PATCH v6 0/3] drop writes to read-only ram device & vfio regions
Date: Thu, 30 Apr 2020 04:07:44 -0400 [thread overview]
Message-ID: <20200430080744.31232-1-yan.y.zhao@intel.com> (raw)
guest writes to read-only memory regions need to be dropped.
patch 1 modifies handler of ram device memory regions to drop guest writes
to read-only ram device memory regions
patch 2 modifies handler of non-mmap'd read-only vfio regions to drop guest
writes to those regions
patch 3 set read-only flag to mmap'd read-only vfio regions, so that guest
writes to those regions would be trapped.
without patch 1, host qemu would then crash on guest write to those
read-only regions.
with patch 1, host qemu would drop the writes.
Changelog:
v6:
-fixed two style alignment problems in patch 1. (Philippe)
v5:
-changed write handler of ram device memory region from .write to
.write_with_attrs in patch 1 (Paolo)
(for vfio region in patch 2, I still keep the operations as .read & .write.
the reasons are:
1. vfio_region_ops are for mmio/pio regions. the top level read/write
dispatcher in kvm just ignores their return values. (the return value of
address_space_rw() is just ignored)
2. there are a lot of callers to vfio_region_read() and
vfio_region_write(), who actually do not care about the return values
)
-minor changes on text format in error logs.
v4:
-instead of modifying tracing log, added qemu_log_mask(LOG_GUEST_ERROR...)
to log guest writes to read-only regions (Philippe)
for
v3:
-refreshed and Cc Stefan for reviewing of tracing part
v2:
-split one big patches into smaller ones (Philippe)
-modify existing trace to record guest writes to read-only memory (Alex)
-modify vfio_region_write() to drop guest writes to non-mmap'd read-only
region (Alex)
Yan Zhao (3):
memory: drop guest writes to read-only ram device regions
hw/vfio: drop guest writes to ro regions
hw/vfio: let read-only flag take effect for mmap'd regions
hw/vfio/common.c | 17 +++++++++++++++--
memory.c | 15 ++++++++++++---
2 files changed, 27 insertions(+), 5 deletions(-)
--
2.17.1
next reply other threads:[~2020-04-30 8:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 8:07 Yan Zhao [this message]
2020-04-30 8:09 ` [PATCH v6 1/3] memory: drop guest writes to read-only ram device regions Yan Zhao
2020-04-30 9:40 ` Peter Maydell
2020-04-30 10:11 ` Yan Zhao
2020-05-21 14:38 ` Paolo Bonzini
2020-05-25 1:18 ` Yan Zhao
2020-05-25 10:20 ` Paolo Bonzini
2020-05-25 10:54 ` Philippe Mathieu-Daudé
2020-05-25 11:04 ` Paolo Bonzini
2020-05-26 2:11 ` Yan Zhao
2020-05-26 9:14 ` Peter Maydell
2020-05-26 9:26 ` Peter Maydell
2020-05-28 4:35 ` Yan Zhao
2020-05-28 5:10 ` Paolo Bonzini
2020-05-28 6:15 ` Yan Zhao
2020-04-30 8:13 ` [PATCH v6 2/3] hw/vfio: drop guest writes to ro regions Yan Zhao
2020-04-30 8:13 ` [PATCH v6 3/3] hw/vfio: let read-only flag take effect for mmap'd regions Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430080744.31232-1-yan.y.zhao@intel.com \
--to=yan.y.zhao@intel.com \
--cc=alex.williamson@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xin.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).