qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, jsnow@redhat.com,
	qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [PATCH v2 1/4] iotests/283: Use consistent size for source and target
Date: Thu, 30 Apr 2020 16:27:52 +0200	[thread overview]
Message-ID: <20200430142755.315494-2-kwolf@redhat.com> (raw)
In-Reply-To: <20200430142755.315494-1-kwolf@redhat.com>

The test case forgot to specify the null-co size for the target node.
When adding a check to backup that both sizes match, this would fail
because of the size mismatch and not the behaviour that the test really
wanted to test.

Fixes: a541fcc27c98b96da187c7d4573f3270f3ddd283
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 tests/qemu-iotests/283     | 6 +++++-
 tests/qemu-iotests/283.out | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/qemu-iotests/283 b/tests/qemu-iotests/283
index 55b7cff953..44de76effe 100644
--- a/tests/qemu-iotests/283
+++ b/tests/qemu-iotests/283
@@ -72,7 +72,11 @@ to check that crash is fixed :)
 vm = iotests.VM()
 vm.launch()
 
-vm.qmp_log('blockdev-add', **{'node-name': 'target', 'driver': 'null-co'})
+vm.qmp_log('blockdev-add', **{
+    'node-name': 'target',
+    'driver': 'null-co',
+    'size': size,
+})
 
 vm.qmp_log('blockdev-add', **{
     'node-name': 'source',
diff --git a/tests/qemu-iotests/283.out b/tests/qemu-iotests/283.out
index daaf5828c1..d8cff22cc1 100644
--- a/tests/qemu-iotests/283.out
+++ b/tests/qemu-iotests/283.out
@@ -1,4 +1,4 @@
-{"execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name": "target"}}
+{"execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name": "target", "size": 1048576}}
 {"return": {}}
 {"execute": "blockdev-add", "arguments": {"driver": "blkdebug", "image": {"driver": "null-co", "node-name": "base", "size": 1048576}, "node-name": "source"}}
 {"return": {}}
-- 
2.25.3



  reply	other threads:[~2020-04-30 14:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 14:27 [PATCH v2 0/4] backup: Make sure that source and target size match Kevin Wolf
2020-04-30 14:27 ` Kevin Wolf [this message]
2020-04-30 17:43   ` [PATCH v2 1/4] iotests/283: Use consistent size for source and target Vladimir Sementsov-Ogievskiy
2020-04-30 14:27 ` [PATCH v2 2/4] backup: Improve error for bdrv_getlength() failure Kevin Wolf
2020-04-30 14:27 ` [PATCH v2 3/4] backup: Make sure that source and target size match Kevin Wolf
2020-04-30 18:21   ` Vladimir Sementsov-Ogievskiy
2020-05-05 10:03     ` Kevin Wolf
2020-05-06  6:07       ` Vladimir Sementsov-Ogievskiy
2020-05-06  8:02         ` Kevin Wolf
2020-05-06  8:21           ` Vladimir Sementsov-Ogievskiy
2020-04-30 14:27 ` [PATCH v2 4/4] iotests: Backup with different source/target size Kevin Wolf
2020-04-30 18:30   ` Vladimir Sementsov-Ogievskiy
2020-05-05 10:08 ` [PATCH v2 0/4] backup: Make sure that source and target size match Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200430142755.315494-2-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).