From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, alex.bennee@linaro.org
Subject: [PATCH v4 00/18] target/arm: sve load/store improvements
Date: Thu, 30 Apr 2020 09:27:55 -0700 [thread overview]
Message-ID: <20200430162813.17671-1-richard.henderson@linaro.org> (raw)
The goal here is to support MTE, but there's some cleanup to do.
Technically, we have sufficient interfaces in cputlb.c now, but it
requires multiple tlb lookups on different interfaces to do so.
Adding probe_access_flags() allows probing the tlb and getting out
some of the flags buried in the tlb comparator, such as TLB_MMIO
and TLB_WATCHPOINT. In addition, we get no-fault semantics,
which we don't have via probe_acccess().
Looking forward to MTE, we can examine the Tagged bit on a per-page
basis and avoid dozens of mte_check calls that must be Unchecked.
That comes later, in a new version of the MTE patch set, but I do
add comments for where the checks should be added.
Version 4 addresses some review comments.
Only 2 patches still unreviewed:
0004-accel-tcg-Add-probe_access_flags.patch
0013-target-arm-Update-contiguous-first-fault-and-no-f.patch
r~
Richard Henderson (18):
exec: Add block comments for watchpoint routines
exec: Fix cpu_watchpoint_address_matches address length
accel/tcg: Add block comment for probe_access
accel/tcg: Add probe_access_flags
accel/tcg: Add endian-specific cpu_{ld,st}* operations
target/arm: Use cpu_*_data_ra for sve_ldst_tlb_fn
target/arm: Drop manual handling of set/clear_helper_retaddr
target/arm: Add sve infrastructure for page lookup
target/arm: Adjust interface of sve_ld1_host_fn
target/arm: Use SVEContLdSt in sve_ld1_r
target/arm: Handle watchpoints in sve_ld1_r
target/arm: Use SVEContLdSt for multi-register contiguous loads
target/arm: Update contiguous first-fault and no-fault loads
target/arm: Use SVEContLdSt for contiguous stores
target/arm: Reuse sve_probe_page for gather first-fault loads
target/arm: Reuse sve_probe_page for scatter stores
target/arm: Reuse sve_probe_page for gather loads
target/arm: Remove sve_memopidx
docs/devel/loads-stores.rst | 39 +-
include/exec/cpu-all.h | 13 +-
include/exec/cpu_ldst.h | 283 +++--
include/exec/exec-all.h | 39 +
include/hw/core/cpu.h | 23 +
target/arm/internals.h | 5 -
accel/tcg/cputlb.c | 413 ++++---
accel/tcg/user-exec.c | 256 +++-
exec.c | 2 +-
target/arm/sve_helper.c | 2241 +++++++++++++++++++----------------
target/arm/translate-sve.c | 17 +-
11 files changed, 1999 insertions(+), 1332 deletions(-)
--
2.20.1
next reply other threads:[~2020-04-30 16:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 16:27 Richard Henderson [this message]
2020-04-30 16:27 ` [PATCH v4 01/18] exec: Add block comments for watchpoint routines Richard Henderson
2020-04-30 16:27 ` [PATCH v4 02/18] exec: Fix cpu_watchpoint_address_matches address length Richard Henderson
2020-04-30 16:27 ` [PATCH v4 03/18] accel/tcg: Add block comment for probe_access Richard Henderson
2020-04-30 16:27 ` [PATCH v4 04/18] accel/tcg: Add probe_access_flags Richard Henderson
2020-04-30 16:28 ` [PATCH v4 05/18] accel/tcg: Add endian-specific cpu_{ld, st}* operations Richard Henderson
2020-04-30 16:28 ` [PATCH v4 06/18] target/arm: Use cpu_*_data_ra for sve_ldst_tlb_fn Richard Henderson
2020-04-30 16:28 ` [PATCH v4 07/18] target/arm: Drop manual handling of set/clear_helper_retaddr Richard Henderson
2020-04-30 16:28 ` [PATCH v4 08/18] target/arm: Add sve infrastructure for page lookup Richard Henderson
2020-04-30 16:28 ` [PATCH v4 09/18] target/arm: Adjust interface of sve_ld1_host_fn Richard Henderson
2020-04-30 16:28 ` [PATCH v4 10/18] target/arm: Use SVEContLdSt in sve_ld1_r Richard Henderson
2020-04-30 16:28 ` [PATCH v4 11/18] target/arm: Handle watchpoints " Richard Henderson
2020-04-30 16:28 ` [PATCH v4 12/18] target/arm: Use SVEContLdSt for multi-register contiguous loads Richard Henderson
2020-04-30 16:28 ` [PATCH v4 13/18] target/arm: Update contiguous first-fault and no-fault loads Richard Henderson
2020-05-04 9:42 ` Peter Maydell
2020-04-30 16:28 ` [PATCH v4 14/18] target/arm: Use SVEContLdSt for contiguous stores Richard Henderson
2020-04-30 16:28 ` [PATCH v4 15/18] target/arm: Reuse sve_probe_page for gather first-fault loads Richard Henderson
2020-04-30 16:28 ` [PATCH v4 16/18] target/arm: Reuse sve_probe_page for scatter stores Richard Henderson
2020-04-30 16:28 ` [PATCH v4 17/18] target/arm: Reuse sve_probe_page for gather loads Richard Henderson
2020-04-30 16:28 ` [PATCH v4 18/18] target/arm: Remove sve_memopidx Richard Henderson
2020-05-01 6:18 ` [PATCH v4 00/18] target/arm: sve load/store improvements no-reply
2020-05-04 9:43 ` Peter Maydell
2020-05-04 16:03 ` Richard Henderson
2020-05-05 9:49 ` Peter Maydell
2020-05-05 14:04 ` Richard Henderson
2020-05-05 14:15 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430162813.17671-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).