From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, alex.bennee@linaro.org
Subject: [PATCH v4 02/18] exec: Fix cpu_watchpoint_address_matches address length
Date: Thu, 30 Apr 2020 09:27:57 -0700 [thread overview]
Message-ID: <20200430162813.17671-3-richard.henderson@linaro.org> (raw)
In-Reply-To: <20200430162813.17671-1-richard.henderson@linaro.org>
The only caller of cpu_watchpoint_address_matches passes
TARGET_PAGE_SIZE, so the bug is not currently visible.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index 2874bb5088..5162f0d12f 100644
--- a/exec.c
+++ b/exec.c
@@ -1127,7 +1127,7 @@ int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len)
int ret = 0;
QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) {
- if (watchpoint_address_matches(wp, addr, TARGET_PAGE_SIZE)) {
+ if (watchpoint_address_matches(wp, addr, len)) {
ret |= wp->flags;
}
}
--
2.20.1
next prev parent reply other threads:[~2020-04-30 16:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 16:27 [PATCH v4 00/18] target/arm: sve load/store improvements Richard Henderson
2020-04-30 16:27 ` [PATCH v4 01/18] exec: Add block comments for watchpoint routines Richard Henderson
2020-04-30 16:27 ` Richard Henderson [this message]
2020-04-30 16:27 ` [PATCH v4 03/18] accel/tcg: Add block comment for probe_access Richard Henderson
2020-04-30 16:27 ` [PATCH v4 04/18] accel/tcg: Add probe_access_flags Richard Henderson
2020-04-30 16:28 ` [PATCH v4 05/18] accel/tcg: Add endian-specific cpu_{ld, st}* operations Richard Henderson
2020-04-30 16:28 ` [PATCH v4 06/18] target/arm: Use cpu_*_data_ra for sve_ldst_tlb_fn Richard Henderson
2020-04-30 16:28 ` [PATCH v4 07/18] target/arm: Drop manual handling of set/clear_helper_retaddr Richard Henderson
2020-04-30 16:28 ` [PATCH v4 08/18] target/arm: Add sve infrastructure for page lookup Richard Henderson
2020-04-30 16:28 ` [PATCH v4 09/18] target/arm: Adjust interface of sve_ld1_host_fn Richard Henderson
2020-04-30 16:28 ` [PATCH v4 10/18] target/arm: Use SVEContLdSt in sve_ld1_r Richard Henderson
2020-04-30 16:28 ` [PATCH v4 11/18] target/arm: Handle watchpoints " Richard Henderson
2020-04-30 16:28 ` [PATCH v4 12/18] target/arm: Use SVEContLdSt for multi-register contiguous loads Richard Henderson
2020-04-30 16:28 ` [PATCH v4 13/18] target/arm: Update contiguous first-fault and no-fault loads Richard Henderson
2020-05-04 9:42 ` Peter Maydell
2020-04-30 16:28 ` [PATCH v4 14/18] target/arm: Use SVEContLdSt for contiguous stores Richard Henderson
2020-04-30 16:28 ` [PATCH v4 15/18] target/arm: Reuse sve_probe_page for gather first-fault loads Richard Henderson
2020-04-30 16:28 ` [PATCH v4 16/18] target/arm: Reuse sve_probe_page for scatter stores Richard Henderson
2020-04-30 16:28 ` [PATCH v4 17/18] target/arm: Reuse sve_probe_page for gather loads Richard Henderson
2020-04-30 16:28 ` [PATCH v4 18/18] target/arm: Remove sve_memopidx Richard Henderson
2020-05-01 6:18 ` [PATCH v4 00/18] target/arm: sve load/store improvements no-reply
2020-05-04 9:43 ` Peter Maydell
2020-05-04 16:03 ` Richard Henderson
2020-05-05 9:49 ` Peter Maydell
2020-05-05 14:04 ` Richard Henderson
2020-05-05 14:15 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430162813.17671-3-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).