qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v1 7/9] tests/guest-debug: use the unix socket for linux-user tests
Date: Thu, 30 Apr 2020 20:01:20 +0100	[thread overview]
Message-ID: <20200430190122.4592-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200430190122.4592-1-alex.bennee@linaro.org>

Now we have support for debugging over a unix socket for linux-user
lets use it in our test harness.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/guest-debug/run-test.py | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/tests/guest-debug/run-test.py b/tests/guest-debug/run-test.py
index 2bbb8fbaa3..d9af9573b9 100755
--- a/tests/guest-debug/run-test.py
+++ b/tests/guest-debug/run-test.py
@@ -15,6 +15,8 @@ import argparse
 import subprocess
 import shutil
 import shlex
+import os
+from tempfile import TemporaryDirectory
 
 def get_args():
     parser = argparse.ArgumentParser(description="A gdbstub test runner")
@@ -41,11 +43,15 @@ if __name__ == '__main__':
         print("We need gdb to run the test")
         exit(-1)
 
+    socket_dir = TemporaryDirectory("qemu-gdbstub")
+    socket_name = os.path.join(socket_dir.name, "gdbstub.socket")
+
     # Launch QEMU with binary
     if "system" in args.qemu:
         cmd = "%s %s %s -s -S" % (args.qemu, args.qargs, args.binary)
     else:
-        cmd = "%s %s -g 1234 %s" % (args.qemu, args.qargs, args.binary)
+        cmd = "%s %s -g %s %s" % (args.qemu, args.qargs, socket_name,
+                                  args.binary)
 
     inferior = subprocess.Popen(shlex.split(cmd))
 
@@ -56,7 +62,10 @@ if __name__ == '__main__':
     # disable prompts in case of crash
     gdb_cmd += " -ex 'set confirm off'"
     # connect to remote
-    gdb_cmd += " -ex 'target remote localhost:1234'"
+    if "system" in args.qemu:
+        gdb_cmd += " -ex 'target remote localhost:1234'"
+    else:
+        gdb_cmd += " -ex 'target remote %s'" % (socket_name)
     # finally the test script itself
     gdb_cmd += " -x %s" % (args.test)
 
-- 
2.20.1



  parent reply	other threads:[~2020-04-30 19:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 19:01 [PATCH v1 0/9] gdbstub/next Alex Bennée
2020-04-30 19:01 ` [PATCH v1 1/9] configure: favour gdb-multiarch if we have it Alex Bennée
2020-05-01 12:25   ` Philippe Mathieu-Daudé
2020-05-01 13:22     ` Alex Bennée
2020-04-30 19:01 ` [PATCH v1 2/9] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers Alex Bennée
2020-05-01 14:34   ` Richard Henderson
2020-04-30 19:01 ` [PATCH v1 3/9] tests/tcg: better trap gdb failures Alex Bennée
2020-04-30 19:01 ` [PATCH v1 4/9] tests/tcg: drop inferior.was_attached() test Alex Bennée
2020-04-30 19:01 ` [PATCH v1 5/9] gdbstub: eliminate gdbserver_fd global Alex Bennée
2020-05-01 12:28   ` Philippe Mathieu-Daudé
2020-05-01 14:35   ` Richard Henderson
2020-04-30 19:01 ` [PATCH v1 6/9] gdbstub/linux-user: support debugging over a unix socket Alex Bennée
2020-05-01 14:43   ` Richard Henderson
2020-04-30 19:01 ` Alex Bennée [this message]
2020-05-01 14:46   ` [PATCH v1 7/9] tests/guest-debug: use the unix socket for linux-user tests Richard Henderson
2020-05-01 14:59     ` Alex Bennée
2020-04-30 19:01 ` [PATCH v1 8/9] tests/tcg: add a multiarch linux-user gdb test Alex Bennée
2020-05-01 14:47   ` Richard Henderson
2020-04-30 19:01 ` [PATCH v1 9/9] target/m68k: fix gdb for m68xxx Alex Bennée
2020-05-01 14:45   ` Richard Henderson
2020-05-01 14:46   ` Laurent Vivier
2020-05-01  7:01 ` [PATCH v1 0/9] gdbstub/next no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200430190122.4592-8-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).