From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: Yan Vugenfirer <yan@daynix.com>, Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v7 0/7] reference implementation of RSS and hash report
Date: Fri, 1 May 2020 10:44:02 -0400 [thread overview]
Message-ID: <20200501104325-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAOEp5OeOcTZM_b254LxX5=jRiiAkGSoLsbMeiMjPs2OoF1MxNA@mail.gmail.com>
We are in freeze so nothing's applied right now.
v8 which has all the bits will be a good step so we
are ready for after freeze.
On Fri, May 01, 2020 at 07:01:58AM +0300, Yuri Benditovich wrote:
> Michael/Jason,
>
> As Linux headers was updated in qemu and now include RSC/RSS/Hash definitions,
> please let me know what you prefer:
> 1. You apply this series as is, then I submit clean-up series that will remove
> all the redundant defines from virtio-net.c
> 2. I post v8 of this series with cleanup of all the redundant defines and also
> RSC ones
> 3. Something other
>
> Thanks,
> Yuri Benditovich
>
> On Tue, Mar 31, 2020 at 5:26 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Sun, Mar 29, 2020 at 06:09:46PM +0300, Yuri Benditovich wrote:
> > Support for VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT
> > features in QEMU for reference purpose.
> > Implements Toeplitz hash calculation for incoming
> > packets according to configuration provided by driver.
> > Uses calculated hash for decision on receive virtqueue
> > and/or reports the hash in the virtio header
>
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Probably post 5.0 material.
>
> > Changes from v6:
> > Fixed a bug in patch 5 "reference implementation of hash report"
> > that caused the ASAN test to fail
> > was: n->rss_data.populate_hash = true;
> > fixed: n->rss_data.populate_hash = !!hash_report;
> >
> > Yuri Benditovich (7):
> > virtio-net: introduce RSS and hash report features
> > virtio-net: implement RSS configuration command
> > virtio-net: implement RX RSS processing
> > tap: allow extended virtio header with hash info
> > virtio-net: reference implementation of hash report
> > vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro
> > virtio-net: add migration support for RSS and hash report
> >
> > hw/net/trace-events | 3 +
> > hw/net/virtio-net.c | 448 +++++++++++++++++++++++++++++++--
> > include/hw/virtio/virtio-net.h | 16 ++
> > include/migration/vmstate.h | 10 +
> > net/tap.c | 11 +-
> > 5 files changed, 460 insertions(+), 28 deletions(-)
> >
> > --
> > 2.17.1
>
>
next prev parent reply other threads:[~2020-05-01 14:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 15:09 [PATCH v7 0/7] reference implementation of RSS and hash report Yuri Benditovich
2020-03-29 15:09 ` [PATCH v7 1/7] virtio-net: introduce RSS and hash report features Yuri Benditovich
2020-03-29 15:09 ` [PATCH v7 2/7] virtio-net: implement RSS configuration command Yuri Benditovich
2020-03-29 15:09 ` [PATCH v7 3/7] virtio-net: implement RX RSS processing Yuri Benditovich
2020-03-29 15:09 ` [PATCH v7 4/7] tap: allow extended virtio header with hash info Yuri Benditovich
2020-03-29 15:09 ` [PATCH v7 5/7] virtio-net: reference implementation of hash report Yuri Benditovich
2020-03-29 15:09 ` [PATCH v7 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro Yuri Benditovich
2020-03-29 15:09 ` [PATCH v7 7/7] virtio-net: add migration support for RSS and hash report Yuri Benditovich
2020-03-31 14:26 ` [PATCH v7 0/7] reference implementation of " Michael S. Tsirkin
2020-05-01 4:01 ` Yuri Benditovich
2020-05-01 14:44 ` Michael S. Tsirkin [this message]
2020-05-01 16:40 ` Michael S. Tsirkin
2020-05-06 5:37 ` Jason Wang
2020-05-06 8:08 ` Yuri Benditovich
2020-05-01 16:41 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501104325-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).