qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/1] Patch for keycodemapdb
@ 2020-04-29 18:41 Volker Rümelin
  2020-04-29 18:42 ` [PATCH 1/1] Fix win32 keycode for VK_OEM_102 Volker Rümelin
  0 siblings, 1 reply; 3+ messages in thread
From: Volker Rümelin @ 2020-04-29 18:41 UTC (permalink / raw)
  To: Daniel P. Berrangé; +Cc: QEMU

Hi Daniel,

here is a patch for keycodemapdb. With this patch I have a working '<' key (the key right of the left shift key on my german keyboard) in my qemu -display gtk guests on Windows.

With best regards,
Volker


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] Fix win32 keycode for VK_OEM_102
  2020-04-29 18:41 [PATCH 0/1] Patch for keycodemapdb Volker Rümelin
@ 2020-04-29 18:42 ` Volker Rümelin
  2020-05-01 15:44   ` Daniel P. Berrangé
  0 siblings, 1 reply; 3+ messages in thread
From: Volker Rümelin @ 2020-04-29 18:42 UTC (permalink / raw)
  To: Daniel P . Berrangé; +Cc: QEMU

The win32 keycode for VK_OEM_102 is 0xe2. The Microsoft docu-
mentation for virtual-key codes agrees with mingw32/winuser.h.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
 data/keymaps.csv | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/keymaps.csv b/data/keymaps.csv
index bc2376c..8111047 100644
--- a/data/keymaps.csv
+++ b/data/keymaps.csv
@@ -145,7 +145,7 @@ KEY_KPDOT,83,ANSI_KeypadDecimal,0x41,0x53,0x71,0x71,99,VK_DECIMAL,0x6e,83,83,XK_
 KEY_KPDOT,83,ANSI_KeypadDecimal,0x41,0x53,0x71,0x71,99,VK_DECIMAL,0x6e,83,83,XK_KP_Decimal,0xffae,NumpadDecimal,KPDC,kp_decimal,0x32,0x41
 ,84,,,0x54,,,,,,,,,,,,,,
 KEY_ZENKAKUHANKAKU,85,,,0x76,0x5f,,148,,,,,,,Lang5,HZTG,,,
-KEY_102ND,86,,,0x56,0x61,0x13,100,VK_OEM_102,0xe1,86,86,,,IntlBackslash,LSGT,less,0x7c,
+KEY_102ND,86,,,0x56,0x61,0x13,100,VK_OEM_102,0xe2,86,86,,,IntlBackslash,LSGT,less,0x7c,
 KEY_F11,87,F11,0x67,0x57,0x78,0x56,68,VK_F11,0x7a,87,87,XK_F11,0xffc8,F11,FK11,f11,0x09,0x67
 KEY_F12,88,F12,0x6f,0x58,0x07,0x5e,69,VK_F12,0x7b,88,88,XK_F12,0xffc9,F12,FK12,f12,0x0b,0x6f
 KEY_RO,89,,,0x73,0x51,,135,,,,,,,IntlRo,AB11,ro,,
-- 
2.16.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] Fix win32 keycode for VK_OEM_102
  2020-04-29 18:42 ` [PATCH 1/1] Fix win32 keycode for VK_OEM_102 Volker Rümelin
@ 2020-05-01 15:44   ` Daniel P. Berrangé
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2020-05-01 15:44 UTC (permalink / raw)
  To: Volker Rümelin; +Cc: QEMU

On Wed, Apr 29, 2020 at 08:42:50PM +0200, Volker Rümelin wrote:
> The win32 keycode for VK_OEM_102 is 0xe2. The Microsoft docu-
> mentation for virtual-key codes agrees with mingw32/winuser.h.

Yes, I concur. I must have made a typo when entering this.

> 
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---
>  data/keymaps.csv | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

and queued for merge

> 
> diff --git a/data/keymaps.csv b/data/keymaps.csv
> index bc2376c..8111047 100644
> --- a/data/keymaps.csv
> +++ b/data/keymaps.csv
> @@ -145,7 +145,7 @@ KEY_KPDOT,83,ANSI_KeypadDecimal,0x41,0x53,0x71,0x71,99,VK_DECIMAL,0x6e,83,83,XK_
>  KEY_KPDOT,83,ANSI_KeypadDecimal,0x41,0x53,0x71,0x71,99,VK_DECIMAL,0x6e,83,83,XK_KP_Decimal,0xffae,NumpadDecimal,KPDC,kp_decimal,0x32,0x41
>  ,84,,,0x54,,,,,,,,,,,,,,
>  KEY_ZENKAKUHANKAKU,85,,,0x76,0x5f,,148,,,,,,,Lang5,HZTG,,,
> -KEY_102ND,86,,,0x56,0x61,0x13,100,VK_OEM_102,0xe1,86,86,,,IntlBackslash,LSGT,less,0x7c,
> +KEY_102ND,86,,,0x56,0x61,0x13,100,VK_OEM_102,0xe2,86,86,,,IntlBackslash,LSGT,less,0x7c,
>  KEY_F11,87,F11,0x67,0x57,0x78,0x56,68,VK_F11,0x7a,87,87,XK_F11,0xffc8,F11,FK11,f11,0x09,0x67
>  KEY_F12,88,F12,0x6f,0x58,0x07,0x5e,69,VK_F12,0x7b,88,88,XK_F12,0xffc9,F12,FK12,f12,0x0b,0x6f
>  KEY_RO,89,,,0x73,0x51,,135,,,,,,,IntlRo,AB11,ro,,
> -- 
> 2.16.4
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-01 15:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-29 18:41 [PATCH 0/1] Patch for keycodemapdb Volker Rümelin
2020-04-29 18:42 ` [PATCH 1/1] Fix win32 keycode for VK_OEM_102 Volker Rümelin
2020-05-01 15:44   ` Daniel P. Berrangé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).