From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [PATCH 4/6] target/arm: Remove unnecessary range check for VSHL
Date: Fri, 1 May 2020 14:13:43 -0700 [thread overview]
Message-ID: <20200501211345.30410-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20200501211345.30410-1-richard.henderson@linaro.org>
In 1dc8425e551, while converting to gvec, I added an extra range check
against the shift count. This was unnecessary because the encoding of
the shift count produces 0 to the element size - 1.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/translate.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index f730eb5b75..f082384117 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -6126,16 +6126,8 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn)
gen_gvec_sli(size, rd_ofs, rm_ofs, shift,
vec_size, vec_size);
} else { /* VSHL */
- /* Shifts larger than the element size are
- * architecturally valid and results in zero.
- */
- if (shift >= 8 << size) {
- tcg_gen_gvec_dup_imm(size, rd_ofs,
- vec_size, vec_size, 0);
- } else {
- tcg_gen_gvec_shli(size, rd_ofs, rm_ofs, shift,
- vec_size, vec_size);
- }
+ tcg_gen_gvec_shli(size, rd_ofs, rm_ofs, shift,
+ vec_size, vec_size);
}
return 0;
}
--
2.20.1
next prev parent reply other threads:[~2020-05-01 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 21:13 [PATCH 0/6] target/arm: partial vector cleanup Richard Henderson
2020-05-01 21:13 ` [PATCH 1/6] target/arm: Create gen_gvec_[us]sra Richard Henderson
2020-05-01 21:13 ` [PATCH 2/6] target/arm: Create gen_gvec_{u,s}{rshr,rsra} Richard Henderson
2020-05-01 21:13 ` [PATCH 3/6] target/arm: Create gen_gvec_{sri,sli} Richard Henderson
2020-05-01 21:13 ` Richard Henderson [this message]
2020-05-01 21:13 ` [PATCH 5/6] target/arm: Tidy handle_vec_simd_shri Richard Henderson
2020-05-01 21:13 ` [PATCH 6/6] target/arm: Wrap vector compare zero GVecGen2 in GVecGen2Fn Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501211345.30410-5-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).