From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
"Max Reitz" <mreitz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v3 00/15] acpi: i386 tweaks
Date: Mon, 4 May 2020 08:48:51 -0400 [thread overview]
Message-ID: <20200504084831-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200429140003.7336-1-kraxel@redhat.com>
On Wed, Apr 29, 2020 at 03:59:48PM +0200, Gerd Hoffmann wrote:
> First batch of microvm patches, some generic acpi stuff.
> Split the acpi-build.c monster, specifically split the
> pc and q35 and pci bits into a separate file which we
> can skip building at some point in the future.
OK I applied 1st part of this that got acks.
> v2 changes: leave acpi-build.c largely as-is, move useful
> bits to other places to allow them being reused, specifically:
>
> * move isa device generator functions to individual isa devices.
> * move fw_cfg generator function to fw_cfg.c
>
> v3 changes: fix rtc, support multiple lpt devices.
>
> take care,
> Gerd
>
> Gerd Hoffmann (15):
> move 'typedef Aml' to qemu/types.h
> acpi: add aml builder stubs
> qtest: allow DSDT acpi table changes
> acpi: drop pointless _STA method
> acpi: add ISADeviceClass->build_aml()
> rtc: add RTC_ISA_BASE
> acpi: move aml builder code for rtc device
> acpi: serial: don't use _STA method
> acpi: move aml builder code for serial device
> acpi: parallel: don't use _STA method
> acpi: move aml builder code for parallel device
> acpi: move aml builder code for floppy device
> acpi: move aml builder code for i8042 (kbd+mouse) device
> acpi: factor out fw_cfg_add_acpi_dsdt()
> acpi: simplify build_isa_devices_aml()
>
> hw/i386/fw_cfg.h | 1 +
> include/hw/acpi/aml-build.h | 1 -
> include/hw/isa/isa.h | 2 +
> include/hw/rtc/mc146818rtc.h | 1 +
> include/qemu/typedefs.h | 1 +
> tests/qtest/bios-tables-test-allowed-diff.h | 17 ++
> hw/acpi/aml-build-stub.c | 79 ++++++
> hw/block/fdc.c | 83 ++++++
> hw/char/parallel.c | 32 +++
> hw/char/serial-isa.c | 32 +++
> hw/i386/acpi-build.c | 271 +-------------------
> hw/i386/fw_cfg.c | 28 ++
> hw/input/pckbd.c | 31 +++
> hw/isa/isa-bus.c | 15 ++
> hw/rtc/mc146818rtc.c | 25 +-
> stubs/cmos.c | 7 +
> hw/acpi/Makefile.objs | 4 +-
> stubs/Makefile.objs | 1 +
> 18 files changed, 361 insertions(+), 270 deletions(-)
> create mode 100644 hw/acpi/aml-build-stub.c
> create mode 100644 stubs/cmos.c
>
> --
> 2.18.2
prev parent reply other threads:[~2020-05-04 12:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 13:59 [PATCH v3 00/15] acpi: i386 tweaks Gerd Hoffmann
2020-04-29 13:59 ` [PATCH v3 01/15] move 'typedef Aml' to qemu/types.h Gerd Hoffmann
2020-04-30 6:35 ` Philippe Mathieu-Daudé
2020-04-29 13:59 ` [PATCH v3 02/15] acpi: add aml builder stubs Gerd Hoffmann
2020-04-29 13:59 ` [PATCH v3 03/15] qtest: allow DSDT acpi table changes Gerd Hoffmann
2020-04-29 13:59 ` [PATCH v3 04/15] acpi: drop pointless _STA method Gerd Hoffmann
2020-04-30 6:35 ` Philippe Mathieu-Daudé
2020-04-29 13:59 ` [PATCH v3 05/15] acpi: add ISADeviceClass->build_aml() Gerd Hoffmann
2020-04-29 13:59 ` [PATCH v3 06/15] rtc: add RTC_ISA_BASE Gerd Hoffmann
2020-04-30 6:35 ` Philippe Mathieu-Daudé
2020-04-30 12:06 ` Igor Mammedov
2020-04-29 13:59 ` [PATCH v3 07/15] acpi: move aml builder code for rtc device Gerd Hoffmann
2020-04-30 12:13 ` Igor Mammedov
2020-04-29 13:59 ` [PATCH v3 08/15] acpi: serial: don't use _STA method Gerd Hoffmann
2020-04-30 6:39 ` Philippe Mathieu-Daudé
2020-05-04 13:19 ` Gerd Hoffmann
2020-05-04 14:47 ` Philippe Mathieu-Daudé
2020-04-29 13:59 ` [PATCH v3 09/15] acpi: move aml builder code for serial device Gerd Hoffmann
2020-04-29 13:59 ` [PATCH v3 10/15] acpi: parallel: don't use _STA method Gerd Hoffmann
2020-04-30 6:43 ` Philippe Mathieu-Daudé
2020-05-04 13:21 ` Gerd Hoffmann
2020-04-30 16:25 ` Igor Mammedov
2020-05-04 13:25 ` Gerd Hoffmann
2020-05-04 16:10 ` Igor Mammedov
2020-04-29 13:59 ` [PATCH v3 11/15] acpi: move aml builder code for parallel device Gerd Hoffmann
2020-04-30 13:43 ` Igor Mammedov
2020-04-29 14:00 ` [PATCH v3 12/15] acpi: move aml builder code for floppy device Gerd Hoffmann
2020-04-30 16:19 ` Igor Mammedov
2020-04-29 14:00 ` [PATCH v3 13/15] acpi: move aml builder code for i8042 (kbd+mouse) device Gerd Hoffmann
2020-04-30 6:50 ` Philippe Mathieu-Daudé
2020-04-30 16:28 ` Igor Mammedov
2020-04-29 14:00 ` [PATCH v3 14/15] acpi: factor out fw_cfg_add_acpi_dsdt() Gerd Hoffmann
2020-04-30 16:31 ` Igor Mammedov
2020-04-29 14:00 ` [PATCH v3 15/15] acpi: simplify build_isa_devices_aml() Gerd Hoffmann
2020-04-30 6:48 ` Philippe Mathieu-Daudé
2020-05-04 13:46 ` Gerd Hoffmann
2020-05-04 14:46 ` Philippe Mathieu-Daudé
2020-04-29 18:31 ` [PATCH v3 00/15] acpi: i386 tweaks no-reply
2020-05-04 12:48 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504084831-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).