From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
qemu-block@nongnu.org, "Maxim Levitsky" <mlevitsk@redhat.com>,
"Keith Busch" <keith.busch@intel.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH 4/6] block/block: Document BlockSizes fields
Date: Mon, 4 May 2020 11:46:39 +0200 [thread overview]
Message-ID: <20200504094641.4963-5-philmd@redhat.com> (raw)
In-Reply-To: <20200504094641.4963-1-philmd@redhat.com>
As it is not obvious for a block neophyte what means
the 'log' value, document it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/block/block.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/block/block.h b/include/block/block.h
index c57fdecf9a..94517c92b6 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -86,8 +86,8 @@ typedef enum {
} BdrvRequestFlags;
typedef struct BlockSizes {
- uint32_t phys;
- uint32_t log;
+ uint32_t phys; /* physical block size */
+ uint32_t log; /* logical block size */
} BlockSizes;
typedef struct HDGeometry {
--
2.21.3
next prev parent reply other threads:[~2020-05-04 9:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 9:46 [PATCH 0/6] block/nvme: Align block pages queue to host page size Philippe Mathieu-Daudé
2020-05-04 9:46 ` [PATCH 1/6] qemu/osdep: Document qemu_memalign() and friends Philippe Mathieu-Daudé
2020-05-07 8:58 ` Stefan Hajnoczi
2020-05-04 9:46 ` [PATCH 2/6] qemu/bitmap: Document bitmap_new() returned pointer Philippe Mathieu-Daudé
2020-05-07 8:58 ` Stefan Hajnoczi
2020-05-04 9:46 ` [PATCH 3/6] sysemu/block-backend: Document blk_read()/blk_pwrite() Philippe Mathieu-Daudé
2020-05-07 8:56 ` Stefan Hajnoczi
2020-05-04 9:46 ` Philippe Mathieu-Daudé [this message]
2020-05-07 8:58 ` [PATCH 4/6] block/block: Document BlockSizes fields Stefan Hajnoczi
2020-05-04 9:46 ` [PATCH 5/6] block/nvme: Align block pages queue to host page size Philippe Mathieu-Daudé
2020-05-05 0:34 ` David Gibson
2020-05-05 8:00 ` Laurent Vivier
2020-05-05 8:23 ` Laurent Vivier
2020-05-05 9:48 ` Philippe Mathieu-Daudé
2020-05-05 15:51 ` Philippe Mathieu-Daudé
2020-05-04 9:46 ` [RFC PATCH 6/6] hw/block/nvme: Make device target agnostic Philippe Mathieu-Daudé
2020-05-04 15:36 ` Philippe Mathieu-Daudé
2020-05-07 10:04 ` Stefan Hajnoczi
2020-05-07 16:24 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504094641.4963-5-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=fam@euphon.net \
--cc=keith.busch@intel.com \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).